This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly][lld] Fix call-indirect.s test to validate
ClosedPublic

Authored by wingo on Nov 30 2020, 6:28 AM.

Details

Summary

Add missing address operand, so that we can validate the output files.

Depends on D92315.

Diff Detail

Event Timeline

wingo created this revision.Nov 30 2020, 6:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 30 2020, 6:28 AM
wingo requested review of this revision.Nov 30 2020, 6:28 AM

Looks like this can land independently can it?

Ready for review; I know that our tests don't have to validate, but sometimes it's useful to be able to check our work using wabt or similar, and in that case non-validating files can be a distraction.

sbc100 accepted this revision.Jan 19 2021, 6:52 AM

I think it would be create if all our tests validated. I wish we have some way to verify that is llvm itself.

This revision is now accepted and ready to land.Jan 19 2021, 6:52 AM
This revision was automatically updated to reflect the committed changes.