Page MenuHomePhabricator

[mlir][Python] Add an Operation.result property.
ClosedPublic

Authored by stellaraccident on Nov 29 2020, 1:54 PM.

Details

Summary
  • If ODS redefines this, it is fine, but I have found this accessor to be universally useful in the old npcomp bindings and I'm closing gaps that will let me switch.

Diff Detail

Event Timeline

stellaraccident requested review of this revision.Nov 29 2020, 1:54 PM
mehdi_amini accepted this revision.Nov 29 2020, 4:17 PM
mehdi_amini added inline comments.
mlir/lib/Bindings/Python/IRModules.cpp
1050

spurious semicolon

2776

Can you augment the message with the operation name and the number of results it has?

2781
This revision is now accepted and ready to land.Nov 29 2020, 4:17 PM
stellaraccident marked 3 inline comments as done.

Address comments.

Also add a using for StringRef and Twine (and replaces fully qualified references).

This revision was landed with ongoing or failed builds.Nov 29 2020, 6:12 PM
This revision was automatically updated to reflect the committed changes.