This is an archive of the discontinued LLVM Phabricator instance.

[DSE] Remove a redundant call to getLocForWriteEx()
ClosedPublic

Authored by gparker42 on Nov 28 2020, 3:56 AM.

Reviewers

asbirlea
fhahn

Commits

Summary

eliminateDeadStoresMemorySSA() makes two identical calls to getLocForWriteEx(). Remove one of them.

I tried formatting this initialization as a ternary expression but it was awful.

LGTM, thanks!

This revision is now accepted and ready to land.Nov 28 2020, 4:38 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

lib/

Transforms/

Scalar/

2 lines

Show First 20 Lines • Show All 2,499 Lines • ▼ Show 20 Lines	bool eliminateDeadStoresMemorySSA(Function &F, AliasAnalysis &AA,
DSEState State = DSEState::get(F, AA, MSSA, DT, PDT, TLI);		DSEState State = DSEState::get(F, AA, MSSA, DT, PDT, TLI);
// For each store:		// For each store:
for (unsigned I = 0; I < State.MemDefs.size(); I++) {		for (unsigned I = 0; I < State.MemDefs.size(); I++) {
MemoryDef *KillingDef = State.MemDefs[I];		MemoryDef *KillingDef = State.MemDefs[I];
if (State.SkipStores.count(KillingDef))		if (State.SkipStores.count(KillingDef))
continue;		continue;
Instruction *SI = KillingDef->getMemoryInst();		Instruction *SI = KillingDef->getMemoryInst();

auto MaybeSILoc = State.getLocForWriteEx(SI);		Optional<MemoryLocation> MaybeSILoc;
if (State.isMemTerminatorInst(SI))		if (State.isMemTerminatorInst(SI))
MaybeSILoc = State.getLocForTerminator(SI).map(		MaybeSILoc = State.getLocForTerminator(SI).map(
[](const std::pair<MemoryLocation, bool> &P) { return P.first; });		[](const std::pair<MemoryLocation, bool> &P) { return P.first; });
else		else
MaybeSILoc = State.getLocForWriteEx(SI);		MaybeSILoc = State.getLocForWriteEx(SI);

if (!MaybeSILoc) {		if (!MaybeSILoc) {
LLVM_DEBUG(dbgs() << "Failed to find analyzable write location for "		LLVM_DEBUG(dbgs() << "Failed to find analyzable write location for "
▲ Show 20 Lines • Show All 270 Lines • Show Last 20 Lines