Page MenuHomePhabricator

gparker42 (Greg Parker)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 14 2016, 11:37 PM (143 w, 5 d)

Recent Activity

Apr 17 2018

gparker42 added a comment to D45601: Warn on bool* to bool conversion.

Note that we recently relaxed a similar diagnostic for NSNumber * in the static analyzer. Such code is semantically similar to inttype *.
https://reviews.llvm.org/D44044

Apr 17 2018, 2:23 AM

Aug 7 2017

gparker42 added a comment to D27214: [ObjC] Encode type arguments in property information string constants.

This won't work. The property attribute string consists of comma-separated fields. The encoding used here embeds commas into the type value, which will break parsing of the attribute string. You'll need to use a separator other than a comma.

Aug 7 2017, 1:39 PM

Jun 29 2017

gparker42 added a comment to D34810: [Sema] -Wcomma should not warn for expressions that return void.

I thought void-returning functions were supposed to be allowed based on the description in https://reviews.llvm.org/D3976 , but later in that discussion the definition was changed to instead allow almost nothing.

Jun 29 2017, 1:28 PM

Jan 24 2017

gparker42 updated the diff for D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.

Reinstate support for REQUIRES-ANY:.

Jan 24 2017, 1:58 AM
gparker42 reopened D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.
Jan 24 2017, 1:55 AM
gparker42 added a comment to D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.

I'll reintroduce REQUIRES-ANY support so there is less disruption for libc++ developers.

Jan 24 2017, 1:50 AM
gparker42 added a comment to D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.

Sorry, I thought libc++ had abandoned REQUIRES-ANY in favor of custom parsers. I just pushed the commit a few minutes ago. I'll revert it until we can coordinate better.

Jan 24 2017, 1:05 AM
gparker42 updated the summary of D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.
Jan 24 2017, 12:32 AM
gparker42 updated the diff for D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.

Add an error message for REQUIRES-ANY: that suggests replacement by a REQUIRES: expression.

Jan 24 2017, 12:32 AM

Jan 19 2017

gparker42 added a comment to D28931: Disable aligned new/delete on Apple platforms without posix_memalign.

No, the old versions of OS X that lack posix_memalign also lack aligned_alloc.

Jan 19 2017, 6:32 PM
gparker42 updated the diff for D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.

Belatedly picking this up again.

  • Resolved conflicts with custom keyword parser machinery in TestRunner.py
  • Updated docs/TestingGuide.rst
  • Loosened identifier syntax, in particular to allow more triple substrings like -linux-.
Jan 19 2017, 5:54 PM

Sep 27 2016

gparker42 added a comment to D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.

Sorry, haven't had time to commit this yet.

Sep 27 2016, 8:14 PM

Sep 1 2016

gparker42 added a comment to D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.

I'll do that. docs/TestingGuide.rst needs to be updated too.

Sep 1 2016, 8:16 PM
gparker42 added a comment to D24111: [lit] Fail testing if a googletest executable crashes during test discovery.

The only other use of capture() in lit itself is capturing sysctl -n hw.ncpu. I didn't look more broadly.

Sep 1 2016, 7:45 PM

Aug 31 2016

gparker42 retitled D24111: [lit] Fail testing if a googletest executable crashes during test discovery from to [lit] Fail testing if a googletest executable crashes during test discovery.
Aug 31 2016, 4:58 PM

Jun 22 2016

gparker42 updated the diff for D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.
  • Changed syntax to C-style ! || && instead of Python-style not or and.
  • Removed REQUIRES-ANY (superseding r 271468)
  • Removed identifier characters ":" and "/"
  • Added identifier characters "." and "+" (used by target triples and libc++)
  • Moved BooleanExpression tests to Python unittest.
Jun 22 2016, 5:51 PM

Mar 24 2016

gparker42 added a comment to D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.

I see 92 test lines using ',' in llvm and clang and swift tests. About half of those of those are XFAILs in llvm, but REQUIRES and UNSUPPORTED are also represented.

Mar 24 2016, 10:21 PM

Mar 17 2016

gparker42 added a reviewer for D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED: ddunbar.
Mar 17 2016, 3:21 PM

Mar 16 2016

gparker42 updated the diff for D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.

Fix an import for Python 3.
Remove a duplicate copy of Test.isEarlyTest().

Mar 16 2016, 5:56 PM
gparker42 added a comment to D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.

, acts as or for UNSUPPORTED and XFAIL but as and for REQUIRES. Also I don't think we want to allow things like REQUIRES: (a, b) and c.

Mar 16 2016, 5:40 PM

Mar 15 2016

gparker42 updated D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.
Mar 15 2016, 5:13 PM
gparker42 updated the diff for D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.

Added a comment about the new throw from Test.isExpectedToFail().
Fixed the run command for lit/tests/requires-missing.txt.

Mar 15 2016, 7:33 AM
gparker42 retitled D18185: [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED from to [lit] Allow boolean expressions in REQUIRES and XFAIL and UNSUPPORTED.
Mar 15 2016, 7:20 AM
gparker42 updated D18182: [test] Don't use UNSUPPORTED in FileCheck prefixes.
Mar 15 2016, 6:35 AM
gparker42 retitled D18182: [test] Don't use UNSUPPORTED in FileCheck prefixes from to [test] Don't use UNSUPPORTED in FileCheck prefixes.
Mar 15 2016, 6:33 AM