This is an archive of the discontinued LLVM Phabricator instance.

Differential D92256

[VE] Specify vector alignments
ClosedPublic

Authored by kaz7 on Nov 27 2020, 7:41 PM.

Details

Reviewers
simoll
k-ishizaka
Commits
rG33eac0f2830e: [VE] Specify vector alignments
Summary

Specify alignments for all vector types. Update a regression test also.

Diff Detail

Event Timeline

kaz7 created this revision.Nov 27 2020, 7:41 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 27 2020, 7:41 PM
Herald added subscribers: llvm-commits, cfe-commits, hiraditya. · View Herald Transcript
kaz7 requested review of this revision.Nov 27 2020, 7:41 PM
Harbormaster completed remote builds in B80398: Diff 308133.Nov 27 2020, 8:22 PM
simoll accepted this revision.Nov 30 2020, 2:10 AM
This revision is now accepted and ready to land.Nov 30 2020, 2:10 AM
This revision was landed with ongoing or failed builds.Nov 30 2020, 5:09 AM
Closed by commit rG33eac0f2830e: [VE] Specify vector alignments (authored by kaz7). · Explain Why
This revision was automatically updated to reflect the committed changes.
kaz7 added a commit: rG33eac0f2830e: [VE] Specify vector alignments.

Revision Contents

PathSize
clang/
lib/
Basic/
Targets/
4 lines
test/
CodeGen/
2 lines
llvm/
lib/
Target/
VE/
13 lines

Diff 308133

clang/lib/Basic/Targets/VE.h

Show All 39 Lines VETargetInfo(const llvm::Triple &Triple, const TargetOptions &)
IntMaxType = SignedLong; IntMaxType = SignedLong;
Int64Type = SignedLong; Int64Type = SignedLong;
RegParmMax = 8; RegParmMax = 8;
MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64; MaxAtomicPromoteWidth = MaxAtomicInlineWidth = 64;
WCharType = UnsignedInt; WCharType = UnsignedInt;
WIntType = UnsignedInt; WIntType = UnsignedInt;
UseZeroLengthBitfieldAlignment = true; UseZeroLengthBitfieldAlignment = true;
resetDataLayout("e-m:e-i64:64-n32:64-S128"); resetDataLayout(
"e-m:e-i64:64-n32:64-S128-v64:64:64-v128:64:64-v256:64:64-v512:64:64-"
"v1024:64:64-v2048:64:64-v4096:64:64-v8192:64:64-v16384:64:64");
} }
void getTargetDefines(const LangOptions &Opts, void getTargetDefines(const LangOptions &Opts,
MacroBuilder &Builder) const override; MacroBuilder &Builder) const override;
bool hasSjLjLowering() const override { bool hasSjLjLowering() const override {
// TODO // TODO
return false; return false;
▲ Show 20 Lines • Show All 121 Lines • Show Last 20 Lines

clang/test/CodeGen/target-data.c

Show First 20 Lines • Show All 275 Lines • ▼ Show 20 Lines
// BPFEL: target datalayout = "e-m:e-p:64:64-i64:64-i128:128-n32:64-S128" // BPFEL: target datalayout = "e-m:e-p:64:64-i64:64-i128:128-n32:64-S128"
// RUN: %clang_cc1 -triple bpfeb -o - -emit-llvm %s | \ // RUN: %clang_cc1 -triple bpfeb -o - -emit-llvm %s | \
// RUN: FileCheck %s -check-prefix=BPFEB // RUN: FileCheck %s -check-prefix=BPFEB
// BPFEB: target datalayout = "E-m:e-p:64:64-i64:64-i128:128-n32:64-S128" // BPFEB: target datalayout = "E-m:e-p:64:64-i64:64-i128:128-n32:64-S128"
// RUN: %clang_cc1 -triple ve -o - -emit-llvm %s | \ // RUN: %clang_cc1 -triple ve -o - -emit-llvm %s | \
// RUN: FileCheck %s -check-prefix=VE // RUN: FileCheck %s -check-prefix=VE
// VE: target datalayout = "e-m:e-i64:64-n32:64-S128" // VE: target datalayout = "e-m:e-i64:64-n32:64-S128-v64:64:64-v128:64:64-v256:64:64-v512:64:64-v1024:64:64-v2048:64:64-v4096:64:64-v8192:64:64-v16384:64:64"

llvm/lib/Target/VE/VETargetMachine.cpp

Show All 38 Linesstatic std::string computeDataLayout(const Triple &T) {
Ret += "-i64:64"; Ret += "-i64:64";
// VE supports 32 bit and 64 bits integer on registers // VE supports 32 bit and 64 bits integer on registers
Ret += "-n32:64"; Ret += "-n32:64";
// Stack alignment is 128 bits // Stack alignment is 128 bits
Ret += "-S128"; Ret += "-S128";
// Vector alignments are 64 bits
// Need to define all of them. Otherwise, each alignment becomes
// the size of each data by default.
Ret += "-v64:64:64"; // for v2f32
Ret += "-v128:64:64";
Ret += "-v256:64:64";
Ret += "-v512:64:64";
Ret += "-v1024:64:64";
Ret += "-v2048:64:64";
Ret += "-v4096:64:64";
Ret += "-v8192:64:64";
Ret += "-v16384:64:64"; // for v256f64
return Ret; return Ret;
} }
static Reloc::Model getEffectiveRelocModel(Optional<Reloc::Model> RM) { static Reloc::Model getEffectiveRelocModel(Optional<Reloc::Model> RM) {
if (!RM.hasValue()) if (!RM.hasValue())
return Reloc::Static; return Reloc::Static;
return *RM; return *RM;
} }
▲ Show 20 Lines • Show All 69 Lines • Show Last 20 Lines