This is an archive of the discontinued LLVM Phabricator instance.

[libc++] Formalize what configurations are covered by the ABI lists
ClosedPublic

Authored by ldionne on Nov 26 2020, 12:32 PM.

Details

Reviewers
None
Group Reviewers
Restricted Project
Commits
rGda1b50d7df21: [libc++] Formalize what configurations are covered by the ABI lists
Summary

By encoding ABI-affecting properties in the name of the ABI list, it
makes it clear when an ABI list test should or should not be available,
and what results we should expect.

Note that we clearly don't encode all ABI-affecting parameters in the
name right now -- I just ported over what we supported in the code that
was there previously. As we encounter configurations that we wish to
support but produce different ABI lists, we can add those to the ABI
identifier and start supporting them.

This commit also starts checking the ABI list in the CI jobs that run
a supported configuration. Eventually, all configurations should have
a generated ABI list and the test should even run implicitly as part of
the Lit test suite.

Diff Detail

Event Timeline

ldionne created this revision.Nov 26 2020, 12:32 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 26 2020, 12:32 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested review of this revision.Nov 26 2020, 12:32 PM
ldionne updated this revision to Diff 307917.Nov 26 2020, 12:55 PM

Don't check ABI lists on the Apple system configuration.
It doesn't enable the debug mode, and we don't have an ABI list for that yet.

ldionne updated this revision to Diff 307928.Nov 26 2020, 2:11 PM

Drop the ABI list checks from the unified standalone build.

The TARGET_TRIPLE isn't set properly by the unified standalone build right now.

ldionne accepted this revision as: Restricted Project.Nov 27 2020, 7:01 AM
This revision was not accepted when it landed; it landed in state Needs Review.Nov 27 2020, 7:01 AM
This revision was automatically updated to reflect the committed changes.
libcxx/lib/abi/CMakeLists.txt