This is an archive of the discontinued LLVM Phabricator instance.

[AArch64] Enable post RA scheduler for Cortex-R82
ClosedPublic

Authored by SjoerdMeijer on Nov 20 2020, 12:47 AM.

Details

Summary

Something I forgot when I added the Cortex-R82.

Diff Detail

Event Timeline

SjoerdMeijer created this revision.Nov 20 2020, 12:47 AM
SjoerdMeijer requested review of this revision.Nov 20 2020, 12:47 AM

Can you add a test line to the fuse-aes test? The postra feature is harder to test very well.

Thanks Dave, I got so excited about not having to test post RA scheduling I forgot about aes ;-)

dmgreen added inline comments.Nov 20 2020, 2:58 AM
llvm/lib/Target/AArch64/AArch64.td
677

If you are adding crypto (which doesn't sound like a bad idea to me), should there be some other tests for that?

If you want to keep this simple and do that in a separate patch, you could just add -mattr=+crypto to the r82 run line.

SjoerdMeijer added inline comments.Nov 20 2020, 3:18 AM
llvm/lib/Target/AArch64/AArch64.td
677

I discovered I need crypto otherwise we get "can't match aes intrinsics" for the fuse aes tests.
I was in two minds what to do here: strip out the fuse aes business here and do that separately, or see what you thought about doing it here. :-).
I like keeping things simple.... not sure if adding -mattr=crypto will really improve things for now as I need to follow up to properly fix it. I.e., I probably need to check more, also clang crypto option passing for the r82 and more tests etc., so let's keep it simple and just do that separately then.

SjoerdMeijer edited the summary of this revision. (Show Details)

Removed FusedAES and Crypto or now.

dmgreen accepted this revision.Nov 20 2020, 4:02 AM

OK fine, sure. Lets just do this bit first. LGTM

This revision is now accepted and ready to land.Nov 20 2020, 4:02 AM
This revision was automatically updated to reflect the committed changes.