This is an archive of the discontinued LLVM Phabricator instance.

Differential D91815

Fix small typo in Block ABI docs
ClosedPublic

Authored by dmaclach on Nov 19 2020, 12:14 PM.

Details

Reviewers
ahatanak
jroelofs
rjmccall
Commits
rGa94bc9d81bfc: Fix small typo in Block ABI docs
Summary

I think the C++ code example had the wrong name for the block copy function.

Diff Detail

Event Timeline

dmaclach requested review of this revision.Nov 19 2020, 12:14 PM
dmaclach created this revision.
dmaclach added a reviewer: ahatanak.
stephanemoore added a subscriber: stephanemoore.Nov 19 2020, 3:19 PM
xgupta added a reviewer: jroelofs.Oct 17 2021, 11:50 PM
jroelofs added a reviewer: rjmccall.Oct 18 2021, 9:08 AM

can you please upload the patch with more context?

git show -U9999 <sha>

rjmccall accepted this revision.Oct 18 2021, 1:53 PM

LGTM

This revision is now accepted and ready to land.Oct 18 2021, 1:53 PM
Closed by commit rGa94bc9d81bfc: Fix small typo in Block ABI docs (authored by dmaclach, committed by xgupta). · Explain WhyOct 18 2021, 9:03 PM
This revision was automatically updated to reflect the committed changes.
xgupta added a commit: rGa94bc9d81bfc: Fix small typo in Block ABI docs.
Herald added a project: Restricted Project. · View Herald TranscriptOct 18 2021, 9:03 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript

Revision Contents

PathSize
clang/
docs/
2 lines

Diff 306504

clang/docs/Block-ABI-Apple.rst

Context not available.
printf("%d\n", _block->foo.value()); printf("%d\n", _block->foo.value());
} }
void __block_literal_10(struct __block_literal_10 *dst, struct __block_literal_10 *src) { void __block_copy_10(struct __block_literal_10 *dst, struct __block_literal_10 *src) {
FOO_ctor(&dst->foo, &src->foo); FOO_ctor(&dst->foo, &src->foo);
} }
Context not available.