Page MenuHomePhabricator

stephanemoore (Stephane Moore)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2015, 4:47 PM (196 w, 4 d)

Recent Activity

Thu, Aug 15

stephanemoore committed rGa53cce943d16: [clang-tidy] Migrate objc-super-self to use isDerivedFrom πŸš› (authored by stephanemoore).
[clang-tidy] Migrate objc-super-self to use isDerivedFrom πŸš›
Thu, Aug 15, 7:28 PM
stephanemoore committed rL369081: [clang-tidy] Migrate objc-super-self to use isDerivedFrom πŸš›.
[clang-tidy] Migrate objc-super-self to use isDerivedFrom πŸš›
Thu, Aug 15, 7:28 PM
stephanemoore closed D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom πŸš›.
Thu, Aug 15, 7:28 PM Β· Restricted Project, Restricted Project
stephanemoore committed rG8c90c1d2d57d: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom πŸš› (authored by stephanemoore).
[clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom πŸš›
Thu, Aug 15, 6:52 PM
stephanemoore committed rL369076: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom πŸš›.
[clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom πŸš›
Thu, Aug 15, 6:51 PM
stephanemoore closed D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom πŸš›.
Thu, Aug 15, 6:51 PM Β· Restricted Project, Restricted Project

Wed, Aug 14

stephanemoore updated the diff for D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom πŸš›.

Fix example matches in comment.

Wed, Aug 14, 8:01 PM Β· Restricted Project, Restricted Project
stephanemoore created D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom πŸš›.
Wed, Aug 14, 7:59 PM Β· Restricted Project, Restricted Project
stephanemoore added reviewers for D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom πŸš›: aaron.ballman, gribozavr.
Wed, Aug 14, 7:04 PM Β· Restricted Project, Restricted Project
stephanemoore created D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom πŸš›.
Wed, Aug 14, 7:01 PM Β· Restricted Project, Restricted Project

Mon, Aug 12

stephanemoore committed rGa0a47d8ac113: [clang] Update isDerivedFrom to support Objective-C classes πŸ” (authored by stephanemoore).
[clang] Update isDerivedFrom to support Objective-C classes πŸ”
Mon, Aug 12, 4:24 PM
stephanemoore committed rL368632: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.
[clang] Update isDerivedFrom to support Objective-C classes πŸ”
Mon, Aug 12, 4:24 PM
stephanemoore closed D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.
Mon, Aug 12, 4:23 PM Β· Restricted Project, Restricted Project

Thu, Aug 8

stephanemoore added inline comments to D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.
Thu, Aug 8, 6:31 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.

Use llvm::SmallPtrSet to store the compatible aliases instead of std::set.
Fix a stray unit test failure in RegistryTest.cpp.

Thu, Aug 8, 6:29 PM Β· Restricted Project, Restricted Project

Wed, Aug 7

stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.

Add tests for isDirectlyDerivedFrom.

Wed, Aug 7, 6:56 PM Β· Restricted Project, Restricted Project
stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.

Whoops; forgot to add test cases for isDirectlyDerivedFrom 🀦 Will do that shortly.

Wed, Aug 7, 6:15 PM Β· Restricted Project, Restricted Project
stephanemoore removed a reviewer for D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”: stephanemoore.
Wed, Aug 7, 5:16 PM Β· Restricted Project, Restricted Project
stephanemoore added a comment to D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.

I spent some time becoming familiar with how isDerivedFrom behaves for C++ classes. I think that I have managed to get the behavior for Objective-C classes to mirror that of C++ classes. Please let me know if I overlooked anything.

Wed, Aug 7, 5:12 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.

Update isDerivedFrom to match aliased types and compatibility aliases of
derived Objective-C classes.

Wed, Aug 7, 5:06 PM Β· Restricted Project, Restricted Project

May 31 2019

stephanemoore committed rGec1982f07f5b: Revise the google-objc-global-variable-declaration check to match the style… (authored by stephanemoore).
Revise the google-objc-global-variable-declaration check to match the style…
May 31 2019, 4:39 PM
stephanemoore committed rL362279: Revise the google-objc-global-variable-declaration check to match the style….
Revise the google-objc-global-variable-declaration check to match the style…
May 31 2019, 4:38 PM
stephanemoore closed D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 31 2019, 4:38 PM Β· Restricted Project, Restricted Project

May 29 2019

stephanemoore accepted D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 29 2019, 8:45 PM Β· Restricted Project, Restricted Project

May 28 2019

stephanemoore added a comment to rL361907: Revise the google-objc-global-variable-declaration check to match the style….

I think your changeset caused a failure in this buildbot.
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/18933
Failure : http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/18933/steps/ninja%20check%201/logs/stdio

May 28 2019, 8:43 PM
stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.

Thanks for the input! I will get started on making changes accordingly.

May 28 2019, 8:24 PM Β· Restricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 28 2019, 7:32 PM Β· Restricted Project, Restricted Project
stephanemoore reopened D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 28 2019, 7:32 PM Β· Restricted Project, Restricted Project
stephanemoore committed rG9ac757bf09a3: Rollback "Revise the google-objc-global-variable-declaration check to match the… (authored by stephanemoore).
Rollback "Revise the google-objc-global-variable-declaration check to match the…
May 28 2019, 7:22 PM
stephanemoore committed rL361914: Rollback "Revise the google-objc-global-variable-declaration check to match the….
Rollback "Revise the google-objc-global-variable-declaration check to match the…
May 28 2019, 7:22 PM
stephanemoore committed rCTE361914: Rollback "Revise the google-objc-global-variable-declaration check to match the….
Rollback "Revise the google-objc-global-variable-declaration check to match the…
May 28 2019, 7:22 PM
stephanemoore committed rG12e3726fadb0: Revise the google-objc-global-variable-declaration check to match the style… (authored by stephanemoore).
Revise the google-objc-global-variable-declaration check to match the style…
May 28 2019, 6:37 PM
stephanemoore committed rL361907: Revise the google-objc-global-variable-declaration check to match the style….
Revise the google-objc-global-variable-declaration check to match the style…
May 28 2019, 6:33 PM
stephanemoore committed rCTE361907: Revise the google-objc-global-variable-declaration check to match the style….
Revise the google-objc-global-variable-declaration check to match the style…
May 28 2019, 6:33 PM
stephanemoore closed D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 28 2019, 6:33 PM Β· Restricted Project, Restricted Project
stephanemoore added a comment to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

It looks like all concerns have been addressed. Do you need me to land this commit for you?

May 28 2019, 1:47 PM Β· Restricted Project, Restricted Project

May 24 2019

stephanemoore requested review of D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.
May 24 2019, 8:36 PM Β· Restricted Project, Restricted Project
stephanemoore accepted D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.

Okay I now have an implementation of Option 2 that works.

May 24 2019, 8:36 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.

Add missing braces to multi-line if statements.

May 24 2019, 8:30 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.

Update isDerivedFrom and related matchers to polymorphic matchers.

May 24 2019, 8:24 PM Β· Restricted Project, Restricted Project
stephanemoore accepted D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Looks good! Thanks for being patient with me!

May 24 2019, 3:45 PM Β· Restricted Project, Restricted Project
stephanemoore accepted D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

(sorry I forgot to send this earlier)

May 24 2019, 3:13 PM Β· Restricted Project, Restricted Project

May 21 2019

stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.

Out of curiosity, how invasive is Option 2 within our own code base?

May 21 2019, 9:00 PM Β· Restricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Many thanks for being patient with me πŸ™ I think there are just two more things ✌️

May 21 2019, 6:18 PM Β· Restricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Almost there. I think everything looks good after we resolve this last round of comments.

May 21 2019, 4:53 PM Β· Restricted Project, Restricted Project

May 17 2019

stephanemoore added inline comments to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 17 2019, 6:09 PM Β· Restricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Thanks for restoring the support for the legacy style! I noticed that there are some cases where we can preserve an existing fixit.

May 17 2019, 3:03 PM Β· Restricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 17 2019, 12:28 PM Β· Restricted Project, Restricted Project

May 14 2019

stephanemoore accepted D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
May 14 2019, 3:08 PM Β· Restricted Project, Restricted Project

May 13 2019

stephanemoore requested changes to D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
May 13 2019, 3:28 PM Β· Restricted Project, Restricted Project
stephanemoore accepted D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

I believe that all the feedback from @gribozavr has been addressed modulo one small nit. Once that nit has been addressed, I can land this.

May 13 2019, 3:09 PM Β· Restricted Project, Restricted Project

May 12 2019

stephanemoore committed rG3109836a60a7: [clang] Regenerate AST matcher docs πŸ“– (authored by stephanemoore).
[clang] Regenerate AST matcher docs πŸ“–
May 12 2019, 2:51 PM
stephanemoore committed rL360545: [clang] Regenerate AST matcher docs πŸ“–.
[clang] Regenerate AST matcher docs πŸ“–
May 12 2019, 2:50 PM
stephanemoore committed rC360545: [clang] Regenerate AST matcher docs πŸ“–.
[clang] Regenerate AST matcher docs πŸ“–
May 12 2019, 2:50 PM
stephanemoore closed D61769: [clang] Regenerate AST matcher docs πŸ“–.
May 12 2019, 2:50 PM Β· Restricted Project, Restricted Project

May 9 2019

stephanemoore added inline comments to D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.
May 9 2019, 5:32 PM Β· Restricted Project, Restricted Project
stephanemoore added a comment to D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.

I did some digging and I believe there are two approaches that we can take to extend isDerivedFrom to support Objective-C classes.

May 9 2019, 5:29 PM Β· Restricted Project, Restricted Project
stephanemoore retitled D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ” from [clang] Add matcher for subclasses of Objective-C interfaces πŸ” to [clang] Update isDerivedFrom to support Objective-C classes πŸ”.
May 9 2019, 5:03 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.

Present one potential option for making isDerivedFrom support Objective-C classes.

May 9 2019, 4:59 PM Β· Restricted Project, Restricted Project
stephanemoore added reviewers for D61769: [clang] Regenerate AST matcher docs πŸ“–: benhamilton, mwyman.
May 9 2019, 4:32 PM Β· Restricted Project, Restricted Project
stephanemoore created D61769: [clang] Regenerate AST matcher docs πŸ“–.
May 9 2019, 4:32 PM Β· Restricted Project, Restricted Project

May 7 2019

stephanemoore accepted D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

Looks good to me once the comments from other reviewers have been addressed. I added a couple suggestions as well.

May 7 2019, 12:41 PM Β· Restricted Project, Restricted Project

Apr 17 2019

stephanemoore committed rGb0c1f8c09e43: [clang-tidy] Add a check for [super self] in initializers πŸ” (authored by stephanemoore).
[clang-tidy] Add a check for [super self] in initializers πŸ”
Apr 17 2019, 3:28 PM
stephanemoore committed rCTE358620: [clang-tidy] Add a check for [super self] in initializers πŸ”.
[clang-tidy] Add a check for [super self] in initializers πŸ”
Apr 17 2019, 3:27 PM
stephanemoore committed rL358620: [clang-tidy] Add a check for [super self] in initializers πŸ”.
[clang-tidy] Add a check for [super self] in initializers πŸ”
Apr 17 2019, 3:27 PM
stephanemoore closed D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.
Apr 17 2019, 3:27 PM Β· Restricted Project, Restricted Project

Apr 16 2019

stephanemoore added a comment to D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.

LGTM! You can either land this now and refactor after the AST matcher lands, or you can wait until the AST matcher lands and land this patch after -- your call.

Apr 16 2019, 8:32 PM Β· Restricted Project, Restricted Project

Apr 15 2019

stephanemoore added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.
Apr 15 2019, 5:23 PM Β· Restricted Project, Restricted Project
stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.
Apr 15 2019, 3:50 PM Β· Restricted Project, Restricted Project

Apr 12 2019

stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.

Fix some formatting issues.

Apr 12 2019, 8:35 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.

Check if either the receiver or selector are in macro locations.

Apr 12 2019, 8:34 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.

Add CHECK-FIXES to verify code is preserved for scenarios that should not have fixes.

Apr 12 2019, 8:16 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.

Update check to avoid emitting a fix if the expression is in a macro.

Apr 12 2019, 8:11 PM Β· Restricted Project, Restricted Project

Apr 10 2019

stephanemoore added inline comments to D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.
Apr 10 2019, 3:20 PM Β· Restricted Project, Restricted Project
stephanemoore added a reviewer for D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”: aaron.ballman.
Apr 10 2019, 3:15 PM Β· Restricted Project, Restricted Project
stephanemoore created D60543: [clang] Update isDerivedFrom to support Objective-C classes πŸ”.
Apr 10 2019, 3:15 PM Β· Restricted Project, Restricted Project
stephanemoore added a comment to D60263: [clang-format] Preserve include blocks in ObjC Google style.

Looks good to me.

Apr 10 2019, 12:07 PM Β· Restricted Project, Restricted Project

Apr 4 2019

stephanemoore planned changes to D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.
Apr 4 2019, 5:57 PM Β· Restricted Project, Restricted Project

Apr 2 2019

stephanemoore added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.
Apr 2 2019, 12:25 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.

Add a test case where a macro emits just self in the message expression.

Apr 2 2019, 12:20 PM Β· Restricted Project, Restricted Project

Mar 29 2019

stephanemoore added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.
Mar 29 2019, 4:20 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.

Add test cases with [super self] expanded from macros.

Mar 29 2019, 4:16 PM Β· Restricted Project, Restricted Project
stephanemoore added a comment to D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.

I don't think there's ever a reason to call [super self], and doing so through a macro could easily indicate a bug.

Mar 29 2019, 3:46 PM Β· Restricted Project, Restricted Project

Mar 26 2019

stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.

Update tests to match updated diagnostic.

Mar 26 2019, 4:04 PM Β· Restricted Project, Restricted Project
stephanemoore added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.
Mar 26 2019, 3:35 PM Β· Restricted Project, Restricted Project
stephanemoore added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.
Mar 26 2019, 3:21 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.

Use double backticks rather than single backticks for symbols in documentation.

Mar 26 2019, 3:18 PM Β· Restricted Project, Restricted Project
stephanemoore added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.
Mar 26 2019, 12:24 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.

Enclose -self in backticks in check documentation (overlooked in previous attempt).

Mar 26 2019, 12:20 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.

Enclose -self in backticks in release notes and check documentation.

Mar 26 2019, 12:18 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.

Fix diagnostic format string to actually use the message's method declaration.

Mar 26 2019, 12:16 PM Β· Restricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.

Removed usage of auto with a nonobvious type in isSubclassOf matcher.
Added backticks around NSObject in docs.
Synchronized check description in release notes and check documentation.

Mar 26 2019, 12:00 PM Β· Restricted Project, Restricted Project

Mar 25 2019

stephanemoore added a reviewer for D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”: aaron.ballman.
Mar 25 2019, 6:25 PM Β· Restricted Project, Restricted Project
stephanemoore updated the summary of D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.
Mar 25 2019, 6:20 PM Β· Restricted Project, Restricted Project
stephanemoore created D59806: [clang-tidy] Add a check for [super self] in initializers πŸ”.
Mar 25 2019, 6:20 PM Β· Restricted Project, Restricted Project

Mar 20 2019

stephanemoore committed rG5f70c473c9c0: [clang-tidy] Disable google-runtime-int in Objective-C++ πŸ”“ (authored by stephanemoore).
[clang-tidy] Disable google-runtime-int in Objective-C++ πŸ”“
Mar 20 2019, 4:05 PM
stephanemoore committed rL356627: [clang-tidy] Disable google-runtime-int in Objective-C++ πŸ”“.
[clang-tidy] Disable google-runtime-int in Objective-C++ πŸ”“
Mar 20 2019, 4:04 PM
stephanemoore committed rCTE356627: [clang-tidy] Disable google-runtime-int in Objective-C++ πŸ”“.
[clang-tidy] Disable google-runtime-int in Objective-C++ πŸ”“
Mar 20 2019, 4:04 PM
stephanemoore closed D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ πŸ”“.
Mar 20 2019, 4:04 PM Β· Restricted Project
stephanemoore added a comment to D59336: [clang-tidy] Disable google-runtime-int in Objective-C++ πŸ”“.

Thanks for the review!

Mar 20 2019, 4:04 PM Β· Restricted Project