- User Since
- Nov 17 2015, 4:47 PM (196 w, 4 d)
Thu, Aug 15
Wed, Aug 14
Fix example matches in comment.
Mon, Aug 12
Thu, Aug 8
Use llvm::SmallPtrSet to store the compatible aliases instead of std::set.
Fix a stray unit test failure in RegistryTest.cpp.
Wed, Aug 7
Add tests for isDirectlyDerivedFrom.
Whoops; forgot to add test cases for isDirectlyDerivedFrom 🤦 Will do that shortly.
I spent some time becoming familiar with how isDerivedFrom behaves for C++ classes. I think that I have managed to get the behavior for Objective-C classes to mirror that of C++ classes. Please let me know if I overlooked anything.
Update isDerivedFrom to match aliased types and compatibility aliases of
derived Objective-C classes.
May 31 2019
May 29 2019
May 28 2019
I think your changeset caused a failure in this buildbot.
Failure : http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/18933/steps/ninja%20check%201/logs/stdio
Thanks for the input! I will get started on making changes accordingly.
It looks like all concerns have been addressed. Do you need me to land this commit for you?
May 24 2019
Okay I now have an implementation of Option 2 that works.
Add missing braces to multi-line if statements.
Update isDerivedFrom and related matchers to polymorphic matchers.
Looks good! Thanks for being patient with me!
(sorry I forgot to send this earlier)
May 21 2019
Out of curiosity, how invasive is Option 2 within our own code base?
Many thanks for being patient with me 🙏 I think there are just two more things ✌️
Almost there. I think everything looks good after we resolve this last round of comments.
May 17 2019
Thanks for restoring the support for the legacy style! I noticed that there are some cases where we can preserve an existing fixit.
May 14 2019
May 13 2019
I believe that all the feedback from @gribozavr has been addressed modulo one small nit. Once that nit has been addressed, I can land this.
May 12 2019
May 9 2019
I did some digging and I believe there are two approaches that we can take to extend isDerivedFrom to support Objective-C classes.
Present one potential option for making isDerivedFrom support Objective-C classes.
May 7 2019
Looks good to me once the comments from other reviewers have been addressed. I added a couple suggestions as well.
Apr 17 2019
Apr 16 2019
Apr 15 2019
Apr 12 2019
Fix some formatting issues.
Check if either the receiver or selector are in macro locations.
Add CHECK-FIXES to verify code is preserved for scenarios that should not have fixes.
Update check to avoid emitting a fix if the expression is in a macro.
Apr 10 2019
Looks good to me.
Apr 4 2019
Apr 2 2019
Add a test case where a macro emits just self in the message expression.
Mar 29 2019
Add test cases with [super self] expanded from macros.
Mar 26 2019
Update tests to match updated diagnostic.
Use double backticks rather than single backticks for symbols in documentation.
Enclose -self in backticks in check documentation (overlooked in previous attempt).
Enclose -self in backticks in release notes and check documentation.
Fix diagnostic format string to actually use the message's method declaration.
Removed usage of auto with a nonobvious type in isSubclassOf matcher.
Added backticks around NSObject in docs.
Synchronized check description in release notes and check documentation.
Mar 25 2019
Mar 20 2019
Thanks for the review!