Page MenuHomePhabricator

stephanemoore (Stephane Moore)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 17 2015, 4:47 PM (204 w, 1 d)

Recent Activity

Tue, Oct 1

stephanemoore committed rGe4acb971f1ea: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock (authored by stephanemoore).
[clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock
Tue, Oct 1, 2:18 PM
stephanemoore committed rL373392: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock.
[clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock
Tue, Oct 1, 2:17 PM
stephanemoore closed D68148: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock.
Tue, Oct 1, 2:17 PM · Restricted Project, Restricted Project, Restricted Project

Mon, Sep 30

stephanemoore added a comment to D65917: [clang-tidy] Added check for the Google style guide's category method naming rule..

(sorry for the delay 😅)

Mon, Sep 30, 5:18 PM · Restricted Project, Restricted Project

Sun, Sep 29

stephanemoore accepted D68148: [clang-tidy] Rename objc-avoid-spinlock check to darwin-avoid-spinlock.

I wasn't sure what the policy is for renaming checks so I dug into previous check renames. https://reviews.llvm.org/D43867 seems to indicate that it's acceptable for checks to be renamed with documentation in the release notes (though there is some discussion about the possibility of recognizing the old check name for a grace period). Based on the aforementioned precedent I don't have concerns with this proposed change.

Sun, Sep 29, 4:33 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 27

stephanemoore added a comment to D68109: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage..

Looks good 👌

Fri, Sep 27, 12:10 PM · Restricted Project, Restricted Project, Restricted Project

Thu, Sep 26

stephanemoore committed rGaa7d6544c14c: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non… (authored by stephanemoore).
[clang-tidy] New check to warn when storing dispatch_once_t in non-static, non…
Thu, Sep 26, 4:04 PM
stephanemoore committed rL373028: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non….
[clang-tidy] New check to warn when storing dispatch_once_t in non-static, non…
Thu, Sep 26, 4:03 PM
stephanemoore closed D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.
Thu, Sep 26, 4:03 PM · Restricted Project, Restricted Project, Restricted Project
stephanemoore added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

It looks like everything is in order. I will proceed with landing the patch on your behalf 👍

Thu, Sep 26, 4:02 PM · Restricted Project, Restricted Project, Restricted Project
stephanemoore accepted D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.
Thu, Sep 26, 2:59 PM · Restricted Project, Restricted Project, Restricted Project
stephanemoore added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

Does the check allow variables in anonymous namespaces?

namespace {
dispatch_once_t onceToken;
}

I think such variables should satisfy initialization requirements.

If not, can we update the check to not trigger on variables? Either way, can we add a test to verify behavior for variables in anonymous namespaces?

Thu, Sep 26, 2:59 PM · Restricted Project, Restricted Project, Restricted Project
stephanemoore added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.

Looks good! A couple nits/questions.

Thu, Sep 26, 2:55 PM · Restricted Project, Restricted Project, Restricted Project

Fri, Sep 20

stephanemoore committed rG2f6a52816fc3: [clang-tidy] Add check for classes missing -hash ⚠️ (authored by stephanemoore).
[clang-tidy] Add check for classes missing -hash ⚠️
Fri, Sep 20, 6:22 PM
stephanemoore committed rL372445: [clang-tidy] Add check for classes missing -hash ⚠️.
[clang-tidy] Add check for classes missing -hash ⚠️
Fri, Sep 20, 6:22 PM
stephanemoore closed D67737: [clang-tidy] Add check for classes missing -hash ⚠️.
Fri, Sep 20, 6:22 PM · Restricted Project, Restricted Project
stephanemoore added a comment to D67737: [clang-tidy] Add check for classes missing -hash ⚠️.

Thanks for the review!

Fri, Sep 20, 5:45 PM · Restricted Project, Restricted Project
stephanemoore requested changes to D65917: [clang-tidy] Added check for the Google style guide's category method naming rule..
Fri, Sep 20, 5:44 PM · Restricted Project, Restricted Project

Thu, Sep 19

stephanemoore added inline comments to D67737: [clang-tidy] Add check for classes missing -hash ⚠️.
Thu, Sep 19, 7:34 PM · Restricted Project, Restricted Project
stephanemoore added inline comments to D67737: [clang-tidy] Add check for classes missing -hash ⚠️.
Thu, Sep 19, 12:48 AM · Restricted Project, Restricted Project
stephanemoore updated the diff for D67737: [clang-tidy] Add check for classes missing -hash ⚠️.

Restrict ojbc-missing-hash to Objective-C language variants and fix sorting of
release notes.

Thu, Sep 19, 12:38 AM · Restricted Project, Restricted Project

Wed, Sep 18

stephanemoore added reviewers for D67737: [clang-tidy] Add check for classes missing -hash ⚠️: aaron.ballman, benhamilton.
Wed, Sep 18, 3:46 PM · Restricted Project, Restricted Project
stephanemoore created D67737: [clang-tidy] Add check for classes missing -hash ⚠️.
Wed, Sep 18, 3:45 PM · Restricted Project, Restricted Project

Tue, Sep 17

stephanemoore added inline comments to D65917: [clang-tidy] Added check for the Google style guide's category method naming rule..
Tue, Sep 17, 1:52 PM · Restricted Project, Restricted Project

Sep 16 2019

stephanemoore requested changes to D65917: [clang-tidy] Added check for the Google style guide's category method naming rule..
Sep 16 2019, 7:08 PM · Restricted Project, Restricted Project
stephanemoore added a comment to D67567: [clang-tidy] New check to warn when storing dispatch_once_t in non-static, non-global storage.
  1. Is dispatch_once_t OSX-specific thing? Should those checks be in osx module?
  1. I don't see an osx module—am I somehow missing seeing it?

One can be added.

dispatch_once_t is something from libdispatchwhich is an Apple-created API, but is OSS and available outside Apple. It's also a C API, which is why I didn't feel objc was an appropriate module either. I'm open to a better home module for this check, it's just not clear to me where that might be.

No opinion on my question, just thought it should be asked,

As Ben commented, I don't feel this should be in an osx module, as libdispatch is highly used on iOS and other Apple platforms. I know it's available elsewhere, but it may be so seldom used that I think a darwinmodule might be reasonable. I looked at the process for creating a new module, and can do that if we'd like, but should that be part of this same review?

Sep 16 2019, 5:05 PM · Restricted Project, Restricted Project, Restricted Project
stephanemoore added inline comments to D67578: [clang-tidy] New check to warn when writing to a dispatch_once_t variable..
Sep 16 2019, 3:31 PM · Restricted Project, Restricted Project

Sep 11 2019

stephanemoore requested changes to D65917: [clang-tidy] Added check for the Google style guide's category method naming rule..
Sep 11 2019, 4:54 AM · Restricted Project, Restricted Project

Aug 15 2019

stephanemoore committed rGa53cce943d16: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛 (authored by stephanemoore).
[clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛
Aug 15 2019, 7:28 PM
stephanemoore committed rL369081: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛.
[clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛
Aug 15 2019, 7:28 PM
stephanemoore closed D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛.
Aug 15 2019, 7:28 PM · Restricted Project, Restricted Project
stephanemoore committed rG8c90c1d2d57d: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛 (authored by stephanemoore).
[clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛
Aug 15 2019, 6:52 PM
stephanemoore committed rL369076: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛.
[clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛
Aug 15 2019, 6:51 PM
stephanemoore closed D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛.
Aug 15 2019, 6:51 PM · Restricted Project, Restricted Project

Aug 14 2019

stephanemoore updated the diff for D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛.

Fix example matches in comment.

Aug 14 2019, 8:01 PM · Restricted Project, Restricted Project
stephanemoore created D66270: [clang-tidy] Migrate objc-super-self to use isDerivedFrom 🚛.
Aug 14 2019, 7:59 PM · Restricted Project, Restricted Project
stephanemoore added reviewers for D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛: aaron.ballman, gribozavr.
Aug 14 2019, 7:04 PM · Restricted Project, Restricted Project
stephanemoore created D66269: [clang-tidy] Migrate objc-forbidden-subclassing to use isDerivedFrom 🚛.
Aug 14 2019, 7:01 PM · Restricted Project, Restricted Project

Aug 12 2019

stephanemoore committed rGa0a47d8ac113: [clang] Update isDerivedFrom to support Objective-C classes 🔍 (authored by stephanemoore).
[clang] Update isDerivedFrom to support Objective-C classes 🔍
Aug 12 2019, 4:24 PM
stephanemoore committed rL368632: [clang] Update isDerivedFrom to support Objective-C classes 🔍.
[clang] Update isDerivedFrom to support Objective-C classes 🔍
Aug 12 2019, 4:24 PM
stephanemoore closed D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.
Aug 12 2019, 4:23 PM · Restricted Project, Restricted Project

Aug 8 2019

stephanemoore added inline comments to D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.
Aug 8 2019, 6:31 PM · Restricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.

Use llvm::SmallPtrSet to store the compatible aliases instead of std::set.
Fix a stray unit test failure in RegistryTest.cpp.

Aug 8 2019, 6:29 PM · Restricted Project, Restricted Project

Aug 7 2019

stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.

Add tests for isDirectlyDerivedFrom.

Aug 7 2019, 6:56 PM · Restricted Project, Restricted Project
stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.

Whoops; forgot to add test cases for isDirectlyDerivedFrom 🤦 Will do that shortly.

Aug 7 2019, 6:15 PM · Restricted Project, Restricted Project
stephanemoore removed a reviewer for D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍: stephanemoore.
Aug 7 2019, 5:16 PM · Restricted Project, Restricted Project
stephanemoore added a comment to D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.

I spent some time becoming familiar with how isDerivedFrom behaves for C++ classes. I think that I have managed to get the behavior for Objective-C classes to mirror that of C++ classes. Please let me know if I overlooked anything.

Aug 7 2019, 5:12 PM · Restricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.

Update isDerivedFrom to match aliased types and compatibility aliases of
derived Objective-C classes.

Aug 7 2019, 5:06 PM · Restricted Project, Restricted Project

May 31 2019

stephanemoore committed rGec1982f07f5b: Revise the google-objc-global-variable-declaration check to match the style… (authored by stephanemoore).
Revise the google-objc-global-variable-declaration check to match the style…
May 31 2019, 4:39 PM
stephanemoore committed rL362279: Revise the google-objc-global-variable-declaration check to match the style….
Revise the google-objc-global-variable-declaration check to match the style…
May 31 2019, 4:38 PM
stephanemoore closed D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 31 2019, 4:38 PM · Restricted Project, Restricted Project

May 29 2019

stephanemoore accepted D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 29 2019, 8:45 PM · Restricted Project, Restricted Project

May 28 2019

stephanemoore added a comment to rL361907: Revise the google-objc-global-variable-declaration check to match the style….

I think your changeset caused a failure in this buildbot.
http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/18933
Failure : http://lab.llvm.org:8011/builders/clang-ppc64le-linux-lnt/builds/18933/steps/ninja%20check%201/logs/stdio

May 28 2019, 8:43 PM
stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.

Thanks for the input! I will get started on making changes accordingly.

May 28 2019, 8:24 PM · Restricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 28 2019, 7:32 PM · Restricted Project, Restricted Project
stephanemoore reopened D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 28 2019, 7:32 PM · Restricted Project, Restricted Project
stephanemoore committed rG9ac757bf09a3: Rollback "Revise the google-objc-global-variable-declaration check to match the… (authored by stephanemoore).
Rollback "Revise the google-objc-global-variable-declaration check to match the…
May 28 2019, 7:22 PM
stephanemoore committed rL361914: Rollback "Revise the google-objc-global-variable-declaration check to match the….
Rollback "Revise the google-objc-global-variable-declaration check to match the…
May 28 2019, 7:22 PM
stephanemoore committed rCTE361914: Rollback "Revise the google-objc-global-variable-declaration check to match the….
Rollback "Revise the google-objc-global-variable-declaration check to match the…
May 28 2019, 7:22 PM
stephanemoore committed rG12e3726fadb0: Revise the google-objc-global-variable-declaration check to match the style… (authored by stephanemoore).
Revise the google-objc-global-variable-declaration check to match the style…
May 28 2019, 6:37 PM
stephanemoore committed rL361907: Revise the google-objc-global-variable-declaration check to match the style….
Revise the google-objc-global-variable-declaration check to match the style…
May 28 2019, 6:33 PM
stephanemoore committed rCTE361907: Revise the google-objc-global-variable-declaration check to match the style….
Revise the google-objc-global-variable-declaration check to match the style…
May 28 2019, 6:33 PM
stephanemoore closed D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 28 2019, 6:33 PM · Restricted Project, Restricted Project
stephanemoore added a comment to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

It looks like all concerns have been addressed. Do you need me to land this commit for you?

May 28 2019, 1:47 PM · Restricted Project, Restricted Project

May 24 2019

stephanemoore requested review of D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.
May 24 2019, 8:36 PM · Restricted Project, Restricted Project
stephanemoore accepted D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.

Okay I now have an implementation of Option 2 that works.

May 24 2019, 8:36 PM · Restricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.

Add missing braces to multi-line if statements.

May 24 2019, 8:30 PM · Restricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.

Update isDerivedFrom and related matchers to polymorphic matchers.

May 24 2019, 8:24 PM · Restricted Project, Restricted Project
stephanemoore accepted D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Looks good! Thanks for being patient with me!

May 24 2019, 3:45 PM · Restricted Project, Restricted Project
stephanemoore accepted D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

(sorry I forgot to send this earlier)

May 24 2019, 3:13 PM · Restricted Project, Restricted Project

May 21 2019

stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.

Out of curiosity, how invasive is Option 2 within our own code base?

May 21 2019, 9:00 PM · Restricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Many thanks for being patient with me 🙏 I think there are just two more things ✌️

May 21 2019, 6:18 PM · Restricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Almost there. I think everything looks good after we resolve this last round of comments.

May 21 2019, 4:53 PM · Restricted Project, Restricted Project

May 17 2019

stephanemoore added inline comments to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 17 2019, 6:09 PM · Restricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..

Thanks for restoring the support for the legacy style! I noticed that there are some cases where we can preserve an existing fixit.

May 17 2019, 3:03 PM · Restricted Project, Restricted Project
stephanemoore requested changes to D62045: Revise the google-objc-global-variable-declaration check to match the style guide..
May 17 2019, 12:28 PM · Restricted Project, Restricted Project

May 14 2019

stephanemoore accepted D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
May 14 2019, 3:08 PM · Restricted Project, Restricted Project

May 13 2019

stephanemoore requested changes to D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.
May 13 2019, 3:28 PM · Restricted Project, Restricted Project
stephanemoore accepted D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

I believe that all the feedback from @gribozavr has been addressed modulo one small nit. Once that nit has been addressed, I can land this.

May 13 2019, 3:09 PM · Restricted Project, Restricted Project

May 12 2019

stephanemoore committed rG3109836a60a7: [clang] Regenerate AST matcher docs 📖 (authored by stephanemoore).
[clang] Regenerate AST matcher docs 📖
May 12 2019, 2:51 PM
stephanemoore committed rL360545: [clang] Regenerate AST matcher docs 📖.
[clang] Regenerate AST matcher docs 📖
May 12 2019, 2:50 PM
stephanemoore committed rC360545: [clang] Regenerate AST matcher docs 📖.
[clang] Regenerate AST matcher docs 📖
May 12 2019, 2:50 PM
stephanemoore closed D61769: [clang] Regenerate AST matcher docs 📖.
May 12 2019, 2:50 PM · Restricted Project, Restricted Project

May 9 2019

stephanemoore added inline comments to D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.
May 9 2019, 5:32 PM · Restricted Project, Restricted Project
stephanemoore added a comment to D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.

I did some digging and I believe there are two approaches that we can take to extend isDerivedFrom to support Objective-C classes.

May 9 2019, 5:29 PM · Restricted Project, Restricted Project
stephanemoore retitled D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍 from [clang] Add matcher for subclasses of Objective-C interfaces 🔍 to [clang] Update isDerivedFrom to support Objective-C classes 🔍.
May 9 2019, 5:03 PM · Restricted Project, Restricted Project
stephanemoore updated the diff for D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.

Present one potential option for making isDerivedFrom support Objective-C classes.

May 9 2019, 4:59 PM · Restricted Project, Restricted Project
stephanemoore added reviewers for D61769: [clang] Regenerate AST matcher docs 📖: benhamilton, mwyman.
May 9 2019, 4:32 PM · Restricted Project, Restricted Project
stephanemoore created D61769: [clang] Regenerate AST matcher docs 📖.
May 9 2019, 4:32 PM · Restricted Project, Restricted Project

May 7 2019

stephanemoore accepted D61350: [clang-tidy] New check calling out uses of +new in Objective-C code.

Looks good to me once the comments from other reviewers have been addressed. I added a couple suggestions as well.

May 7 2019, 12:41 PM · Restricted Project, Restricted Project

Apr 17 2019

stephanemoore committed rGb0c1f8c09e43: [clang-tidy] Add a check for [super self] in initializers 🔍 (authored by stephanemoore).
[clang-tidy] Add a check for [super self] in initializers 🔍
Apr 17 2019, 3:28 PM
stephanemoore committed rCTE358620: [clang-tidy] Add a check for [super self] in initializers 🔍.
[clang-tidy] Add a check for [super self] in initializers 🔍
Apr 17 2019, 3:27 PM
stephanemoore committed rL358620: [clang-tidy] Add a check for [super self] in initializers 🔍.
[clang-tidy] Add a check for [super self] in initializers 🔍
Apr 17 2019, 3:27 PM
stephanemoore closed D59806: [clang-tidy] Add a check for [super self] in initializers 🔍.
Apr 17 2019, 3:27 PM · Restricted Project, Restricted Project

Apr 16 2019

stephanemoore added a comment to D59806: [clang-tidy] Add a check for [super self] in initializers 🔍.

LGTM! You can either land this now and refactor after the AST matcher lands, or you can wait until the AST matcher lands and land this patch after -- your call.

Apr 16 2019, 8:32 PM · Restricted Project, Restricted Project

Apr 15 2019

stephanemoore added inline comments to D59806: [clang-tidy] Add a check for [super self] in initializers 🔍.
Apr 15 2019, 5:23 PM · Restricted Project, Restricted Project
stephanemoore planned changes to D60543: [clang] Update isDerivedFrom to support Objective-C classes 🔍.
Apr 15 2019, 3:50 PM · Restricted Project, Restricted Project

Apr 12 2019

stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 🔍.

Fix some formatting issues.

Apr 12 2019, 8:35 PM · Restricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 🔍.

Check if either the receiver or selector are in macro locations.

Apr 12 2019, 8:34 PM · Restricted Project, Restricted Project
stephanemoore updated the diff for D59806: [clang-tidy] Add a check for [super self] in initializers 🔍.

Add CHECK-FIXES to verify code is preserved for scenarios that should not have fixes.

Apr 12 2019, 8:16 PM · Restricted Project, Restricted Project