User Details
- User Since
- Dec 10 2018, 7:47 PM (250 w, 13 h)
Mar 16 2023
Mar 15 2023
Mar 10 2023
usama/rsundahl how do I run an iOS test? I can't do arm, but x86_64 should be equivalent for a dyld problem? Also is there a waterfall for these types of breakages that I don't know about?
Mar 6 2023
Added test in asan. There wasn't an easy spot to put it in the sanitizer_common tests because I wanted to verify that the actual sanitizer libraries were calling through correctly when __sanitizer_report_error_summary was overridden.
Mar 5 2023
Moved to REQUIRES: asan-static-runtime
Mar 3 2023
Went with unsupported.
Mar 2 2023
Updated with fixed tests for replaceable_new_delete.cpp.
Mar 1 2023
Yep. Apologies. Been a long time since I committed anything to LLVM. I'll try and take a look tonight/first thing tomorrow.
@usama54321 or @yln are you able to commit for me?
Feb 27 2023
Switched over to using "sanitizer_sandbox_on_notify" from "sanitizer_print_stack_trace" because it's available in the internal headers and serves the same purpose.
This diff should be buildable. Adding requested test shortly.
Updated with buildable patch.
Accidentally uploaded
Feb 26 2023
Feb 24 2023
Addressed comments. PTAL
Feb 23 2023
Oct 20 2022
LGTM
Sep 9 2022
Thanks Puyan! Awesome to see this moving forward.
May 27 2022
Feb 22 2022
Jul 1 2021
Jun 28 2021
Has anything happened with this at all or did it get dropped?
Nov 19 2020
May 13 2020
So this is probably old news inside of Apple, but this can cause [NSInvocation retainArguments] to crash:
Jan 16 2020
Sep 25 2019
Any other comments on this?
Sep 23 2019
Updated based on review
Fixed up review comments.
Sep 20 2019
May 16 2019
Okay, so I've looked into it a little bit further and it's really just that when we force inlining everything, we basically end up with a lot fewer functions being defined in the object file, and consequently the resulting code is smaller. It's not rocket science and it's what I expected.
Now, what I'm thinking is that perhaps what you might want to do is crank up the inliner using compiler flags instead of trying to influence that in the library. I'm not exactly sure how/whether one can do that, but it seems like what you want may be something like: clang++ -falways-inline or something along those lines. This would have the "added benefit" that all your code would get the same treatment, not only libc++. Does that make sense?
May 14 2019
-O0 for everything I'm complaining about here :)
OK, here's for Google Maps (a mix of ObjC, ObjC++, C++) with multiple TU:
May 13 2019
Chromium bug 961450 is tracking to see if it causes size/performance changes there as well
As a piece of test code:
Hey Louis,
May 10 2019
This change caused some significant bloat and affected our performance and link times.
Dec 13 2018
Akira/John/Erik - any thoughts?
Dec 11 2018
Updated to fix Stephane's good catch of Objective C vs Objective-C
Full Diffs as requested.
Added some spacing around early exit as requested by theraven.