- User Since
- Dec 10 2018, 7:47 PM (191 w, 6 d)
May 27 2022
Feb 22 2022
Jul 1 2021
Jun 28 2021
Has anything happened with this at all or did it get dropped?
Nov 19 2020
May 13 2020
So this is probably old news inside of Apple, but this can cause [NSInvocation retainArguments] to crash:
Jan 16 2020
Sep 25 2019
Any other comments on this?
Sep 23 2019
Updated based on review
Fixed up review comments.
Sep 20 2019
May 16 2019
Okay, so I've looked into it a little bit further and it's really just that when we force inlining everything, we basically end up with a lot fewer functions being defined in the object file, and consequently the resulting code is smaller. It's not rocket science and it's what I expected.
Now, what I'm thinking is that perhaps what you might want to do is crank up the inliner using compiler flags instead of trying to influence that in the library. I'm not exactly sure how/whether one can do that, but it seems like what you want may be something like: clang++ -falways-inline or something along those lines. This would have the "added benefit" that all your code would get the same treatment, not only libc++. Does that make sense?
May 14 2019
-O0 for everything I'm complaining about here :)
OK, here's for Google Maps (a mix of ObjC, ObjC++, C++) with multiple TU:
May 13 2019
Chromium bug 961450 is tracking to see if it causes size/performance changes there as well
As a piece of test code:
May 10 2019
This change caused some significant bloat and affected our performance and link times.
Dec 13 2018
Akira/John/Erik - any thoughts?
Dec 11 2018
Updated to fix Stephane's good catch of Objective C vs Objective-C
Full Diffs as requested.
Added some spacing around early exit as requested by theraven.