So this is probably old news inside of Apple, but this can cause [NSInvocation retainArguments] to crash:

Any other comments on this?

Updated based on review

Fixed up review comments.

Okay, so I've looked into it a little bit further and it's really just that when we force inlining everything, we basically end up with a lot fewer functions being defined in the object file, and consequently the resulting code is smaller. It's not rocket science and it's what I expected.

Now, what I'm thinking is that perhaps what you might want to do is crank up the inliner using compiler flags instead of trying to influence that in the library. I'm not exactly sure how/whether one can do that, but it seems like what you want may be something like: clang++ -falways-inline or something along those lines. This would have the "added benefit" that all your code would get the same treatment, not only libc++. Does that make sense?

-O0 for everything I'm complaining about here :)

OK, here's for Google Maps (a mix of ObjC, ObjC++, C++) with multiple TU:

Chromium bug 961450 is tracking to see if it causes size/performance changes there as well

As a piece of test code:

Hey Louis,

This change caused some significant bloat and affected our performance and link times.

Akira/John/Erik - any thoughts?

Updated to fix Stephane's good catch of Objective C vs Objective-C

Full Diffs as requested.

In D55544#1326956, @theraven wrote:

It would probably be a good idea to have a similar check on properties, as property encoding strings contain the type encoding (plus extra stuff).

Added some spacing around early exit as requested by theraven.