This removes the rest of the llvm dependencies from the libc unit test framework.
(NOT QUITE WORKING) get the rest of the llvm dependencies out StreamWrapper and FDReader
my FDReader change isn't quite working yet but I need to go work on something else and I
don't want to forget to upload this
Needs brackets and no comment
const -> constexpr
Probably left over from testing.
This loop could maybe be
Read will not null terminate the buffer, the input probably won't have a '\0' in it either. I think pipeStr.insert(pipeStr.end(), buffer, bytesRead) or similar is safer.
I think pipeStr == inputStr is more clear
I feel very silly for missing that one. That was why the test was failing immediately.
I made one small change to your code, bytesRead needs to be signed because read uses negative numbers for errors
oops, as I'm sure you guessed I forgot to clean up my code before submitting.