This is an archive of the discontinued LLVM Phabricator instance.

Differential D91613

[mlir][linalg] Allow tensor_to_memref in dependence analysis
ClosedPublic

Authored by herhut on Nov 17 2020, 4:20 AM.

Details

Reviewers
nicolasvasilache
Commits
rGffac5b8e4cc0: [mlir][linalg] Allow tensor_to_memref in dependence analysis
Summary

This enables the use of fusion on buffers in partially lowered
programs.

Diff Detail

Event Timeline

herhut created this revision.Nov 17 2020, 4:20 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 17 2020, 4:20 AM
Herald added subscribers: teijeong, rdzhabarov, tatianashp and 14 others. · View Herald Transcript
herhut requested review of this revision.Nov 17 2020, 4:20 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptNov 17 2020, 4:20 AM
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
Harbormaster completed remote builds in B79087: Diff 305734.Nov 17 2020, 4:36 AM
nicolasvasilache accepted this revision.Nov 17 2020, 5:09 AM
This revision is now accepted and ready to land.Nov 17 2020, 5:09 AM
Closed by commit rGffac5b8e4cc0: [mlir][linalg] Allow tensor_to_memref in dependence analysis (authored by herhut). · Explain WhyNov 17 2020, 5:38 AM
This revision was automatically updated to reflect the committed changes.
herhut added a commit: rGffac5b8e4cc0: [mlir][linalg] Allow tensor_to_memref in dependence analysis.

Revision Contents

PathSize
mlir/
lib/
Dialect/
Linalg/
Analysis/
3 lines

Diff 305734

mlir/lib/Dialect/Linalg/Analysis/DependenceAnalysis.cpp

Show All 37 LinesValue Aliases::find(Value v) {
while (true) { while (true) {
if (v.isa<BlockArgument>()) if (v.isa<BlockArgument>())
return v; return v;
Operation *defOp = v.getDefiningOp(); Operation *defOp = v.getDefiningOp();
if (!defOp) if (!defOp)
return v; return v;
if (isa<TensorToMemrefOp>(defOp))
return v;
if (auto memEffect = dyn_cast<MemoryEffectOpInterface>(defOp)) { if (auto memEffect = dyn_cast<MemoryEffectOpInterface>(defOp)) {
// Collect all memory effects on `v`. // Collect all memory effects on `v`.
SmallVector<MemoryEffects::EffectInstance, 1> effects; SmallVector<MemoryEffects::EffectInstance, 1> effects;
memEffect.getEffectsOnValue(v, effects); memEffect.getEffectsOnValue(v, effects);
// If we have the 'Allocate' memory effect on `v`, then `v` should be the // If we have the 'Allocate' memory effect on `v`, then `v` should be the
// original buffer. // original buffer.
if (llvm::any_of( if (llvm::any_of(
▲ Show 20 Lines • Show All 283 Lines • Show Last 20 Lines