Page MenuHomePhabricator

[Support] Allow customizing the cache pruning prefix
Needs ReviewPublic

Authored by phosek on Nov 16 2020, 11:11 AM.

Details

Reviewers
pcc
Summary

Enable changing the prefix used by the cache pruning implementation.

Diff Detail

Unit TestsFailed

TimeTest
360 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
Script: -- : 'RUN: at line 3'; /mnt/disks/ssd0/agent/llvm-project/build/./bin/clang --driver-mode=g++ -m64 -gline-tables-only -fsanitize=hwaddress -fuse-ld=lld -mcmodel=large -mllvm -hwasan-globals -mllvm -hwasan-use-short-granules -mllvm -hwasan-instrument-landing-pads=0 -mllvm -hwasan-instrument-personality-functions /mnt/disks/ssd0/agent/llvm-project/compiler-rt/test/hwasan/TestCases/sizes.cpp -nostdlib++ -lstdc++ -o /mnt/disks/ssd0/agent/llvm-project/build/projects/compiler-rt/test/hwasan/X86_64/TestCases/Output/sizes.cpp.tmp

Event Timeline

phosek created this revision.Nov 16 2020, 11:11 AM
phosek requested review of this revision.Nov 16 2020, 11:11 AM
pcc added a comment.Nov 16 2020, 11:19 AM

What is the use case?

In D91555#2397902, @pcc wrote:

What is the use case?

We would like to use the cache pruning in one of our downstream tools but we would like to use a custom prefix.

llvm/include/llvm/Support/CachePruning.h
78

Alternatively, we could also make this a part of CachePruningPolicy, I'm not sure if that would be preferable?