Page MenuHomePhabricator

[libc++] Move the GDB pretty printer tests to the DSL
ClosedPublic

Authored by ldionne on Nov 13 2020, 8:58 AM.

Details

Reviewers
saugustine
Group Reviewers
Restricted Project
Commits
rG7ad8e19958b2: [libc++] Move the GDB pretty printer tests to the DSL
Summary

Also, enable them whenever we detect that gdb is available. Previously,
these tests would basically never run because they relied on a CMake
configuration option that defaulted to OFF.

Diff Detail

Event Timeline

ldionne created this revision.Nov 13 2020, 8:58 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 13 2020, 8:58 AM
Herald added a reviewer: Restricted Project. · View Herald Transcript
ldionne requested review of this revision.Nov 13 2020, 8:58 AM

@saugustine I'm seeing failures in the tests right now. Could you please kindly take a look?

Starting with this commit, I'd like us to run these tests all the time, otherwise it's no use having dead code in the repo.

The reason this hasn't been run by default is due to python versioning issues with gdb, the system it runs on, and the tests themselves. There are certain cross-platform issues as well.

What failures are you seeing?

ldionne updated this revision to Diff 305515.Nov 16 2020, 7:42 AM

Mark GDB tests as unsupported when localization is not supported

The reason this hasn't been run by default is due to python versioning issues with gdb, the system it runs on, and the tests themselves. There are certain cross-platform issues as well.

We should strive to detect whether we can run the tests automatically instead, which is what this patch is trying to do. Otherwise, we just end up with code that is never run, which is bad because it eventually rots. What are the requirements of the GDB tests?

What failures are you seeing?

I was seeing some failures locally in the CI Docker image, but I'm not seeing them anymore and the bots seem to be fine, so nevermind!

This revision was not accepted when it landed; it landed in state Needs Review.Nov 16 2020, 1:17 PM
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.