Differential D91369

[NFC] Switch printFunctionLikeOp and parseFunctionLikeOp to only support "inline" visibility.
ClosedPublic
Actions

Authored by jurahul on Nov 12 2020, 10:48 AM.

Details

Reviewers

Commits

rGdea24b422cc2: [NFC] Switch printFunctionLikeOp and parseFunctionLikeOp to only support…

Summary

Remove the default valued arguments from these functions.
Besides FuncOp, looks like no other in-tree op is using these functions.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

jurahul created this revision.Nov 12 2020, 10:48 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 12 2020, 10:48 AM

Herald added subscribers: rdzhabarov, tatianashp, msifontes and 11 others. · View Herald Transcript

jurahul requested review of this revision.Nov 12 2020, 10:48 AM

Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald TranscriptNov 12 2020, 10:48 AM

Thanks for following up on this!

This revision is now accepted and ready to land.Nov 12 2020, 10:49 AM

Harbormaster completed remote builds in B78650: Diff 304902.Nov 12 2020, 11:09 AM

Closed by commit rGdea24b422cc2: [NFC] Switch printFunctionLikeOp and parseFunctionLikeOp to only support… (authored by jurahul). · Explain WhyNov 12 2020, 11:29 AM

This revision was automatically updated to reflect the committed changes.

jurahul added a commit: rGdea24b422cc2: [NFC] Switch printFunctionLikeOp and parseFunctionLikeOp to only support….

Revision Contents
Changeset List

Path

Size

mlir/

include/

mlir/

IR/

FunctionImplementation.h

14 lines

lib/

IR/

6 lines

FunctionImplementation.cpp

27 lines

Diff 304911

mlir/include/mlir/IR/FunctionImplementation.h

Loading...

mlir/lib/IR/Function.cpp

Loading...

mlir/lib/IR/FunctionImplementation.cpp

Loading...