This is an archive of the discontinued LLVM Phabricator instance.

Differential D91335

[DivergenceAnalysis] Use addRequiredTransitive
ClosedPublic

Authored by piotr on Nov 12 2020, 4:35 AM.

Details

Reviewers
rampitec
nhaehnle
arsenm
Commits
rG47dec5aa603b: [DivergenceAnalysis] Use addRequiredTransitive
Summary

For querying divergence the chained analysis passes are required
to be alive, for instance LoopInfoWrapperPass.

Ensure that by using addRequiredTransitive.

Diff Detail

Event Timeline

piotr created this revision.Nov 12 2020, 4:35 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 12 2020, 4:35 AM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
piotr requested review of this revision.Nov 12 2020, 4:35 AM
piotr added reviewers: rampitec, nhaehnle, arsenm.Nov 12 2020, 4:36 AM
Herald added a subscriber: wdng. · View Herald TranscriptNov 12 2020, 4:36 AM
Harbormaster completed remote builds in B78594: Diff 304781.Nov 12 2020, 5:21 AM
arsenm accepted this revision.Nov 12 2020, 9:22 AM
This revision is now accepted and ready to land.Nov 12 2020, 9:22 AM
piotr updated this revision to Diff 305102.Nov 13 2020, 4:47 AM

Rebased to retrigger the buildbot checks.

Harbormaster completed remote builds in B78746: Diff 305102.Nov 13 2020, 5:20 AM
This revision was landed with ongoing or failed builds.Nov 13 2020, 5:40 AM
Closed by commit rG47dec5aa603b: [DivergenceAnalysis] Use addRequiredTransitive (authored by piotr). · Explain Why
This revision was automatically updated to reflect the committed changes.
piotr added a commit: rG47dec5aa603b: [DivergenceAnalysis] Use addRequiredTransitive.

Revision Contents

PathSize
llvm/
lib/
Analysis/
6 lines

Diff 305111

llvm/lib/Analysis/LegacyDivergenceAnalysis.cpp

Show First 20 Lines • Show All 293 Lines • ▼ Show 20 Lines
INITIALIZE_PASS_END(LegacyDivergenceAnalysis, "divergence", INITIALIZE_PASS_END(LegacyDivergenceAnalysis, "divergence",
"Legacy Divergence Analysis", false, true) "Legacy Divergence Analysis", false, true)
FunctionPass *llvm::createLegacyDivergenceAnalysisPass() { FunctionPass *llvm::createLegacyDivergenceAnalysisPass() {
return new LegacyDivergenceAnalysis(); return new LegacyDivergenceAnalysis();
} }
void LegacyDivergenceAnalysis::getAnalysisUsage(AnalysisUsage &AU) const { void LegacyDivergenceAnalysis::getAnalysisUsage(AnalysisUsage &AU) const {
AU.addRequired<DominatorTreeWrapperPass>(); AU.addRequiredTransitive<DominatorTreeWrapperPass>();
AU.addRequired<PostDominatorTreeWrapperPass>(); AU.addRequiredTransitive<PostDominatorTreeWrapperPass>();
AU.addRequired<LoopInfoWrapperPass>(); AU.addRequiredTransitive<LoopInfoWrapperPass>();
AU.setPreservesAll(); AU.setPreservesAll();
} }
bool LegacyDivergenceAnalysis::shouldUseGPUDivergenceAnalysis( bool LegacyDivergenceAnalysis::shouldUseGPUDivergenceAnalysis(
const Function &F, const TargetTransformInfo &TTI) const { const Function &F, const TargetTransformInfo &TTI) const {
if (!(UseGPUDA || TTI.useGPUDivergenceAnalysis())) if (!(UseGPUDA || TTI.useGPUDivergenceAnalysis()))
return false; return false;
▲ Show 20 Lines • Show All 96 Lines • Show Last 20 Lines