This is an archive of the discontinued LLVM Phabricator instance.

Differential D91329

[NewPM] Re-enable PreserveCFGChecker
AbandonedPublic

Authored by yrouban on Nov 12 2020, 1:05 AM.

Details

Reviewers
skatkov
kuhar
asbirlea
fedor.sergeev
Summary

Enable the redesigned PreserveCFGChecker (D91327) for debug builds by setting the default value of the option -verify-cfg-preserved.

Diff Detail

Unit TestsFailed

TimeTest
410 mslinux > HWAddressSanitizer-x86_64.TestCases::sizes.cpp
200 mslinux > LLVM.Other::new-pm-thinlto-defaults.ll
50 mslinux > LLVM.Other::new-pm-thinlto-prelink-samplepgo-defaults.ll
450 mswindows > LLVM.Other::new-pm-thinlto-defaults.ll
80 mswindows > LLVM.Other::new-pm-thinlto-prelink-samplepgo-defaults.ll

Event Timeline

yrouban created this revision.Nov 12 2020, 1:05 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 12 2020, 1:05 AM
Herald added a subscriber: hiraditya. · View Herald Transcript
yrouban requested review of this revision.Nov 12 2020, 1:05 AM
yrouban added a parent revision: D91327: [NewPM] Redesign of PreserveCFG Checker.
Harbormaster completed remote builds in B78578: Diff 304744.Nov 12 2020, 2:06 AM
yrouban abandoned this revision.Feb 23 2022, 9:24 PM

Closed by commit b5c63e30ca1af7e36ba5069eb0121d1eb4b06ebb.

Revision Contents

PathSize
llvm/
lib/
Passes/
2 lines

Diff 304744

llvm/lib/Passes/StandardInstrumentations.cpp

Show All 37 Lines EnableOptnone("enable-npm-optnone", cl::init(true),
cl::desc("Enable skipping optional passes optnone functions " cl::desc("Enable skipping optional passes optnone functions "
"under new pass manager")); "under new pass manager"));
cl::opt<bool> PreservedCFGCheckerInstrumentation::VerifyPreservedCFG( cl::opt<bool> PreservedCFGCheckerInstrumentation::VerifyPreservedCFG(
"verify-cfg-preserved", cl::Hidden, "verify-cfg-preserved", cl::Hidden,
#ifdef NDEBUG #ifdef NDEBUG
cl::init(false)); cl::init(false));
#else #else
cl::init(false)); cl::init(true));
#endif #endif
// FIXME: Change `-debug-pass-manager` from boolean to enum type. Similar to // FIXME: Change `-debug-pass-manager` from boolean to enum type. Similar to
// `-debug-pass` in legacy PM. // `-debug-pass` in legacy PM.
static cl::opt<bool> static cl::opt<bool>
DebugPMVerbose("debug-pass-manager-verbose", cl::Hidden, cl::init(false), DebugPMVerbose("debug-pass-manager-verbose", cl::Hidden, cl::init(false),
cl::desc("Print all pass management debugging information. " cl::desc("Print all pass management debugging information. "
"`-debug-pass-manager` must also be specified")); "`-debug-pass-manager` must also be specified"));
▲ Show 20 Lines • Show All 797 Lines • Show Last 20 Lines