This is an archive of the discontinued LLVM Phabricator instance.

[ARM] Fix PR 47980: Use constrainRegClass during foldImmediate opt.
ClosedPublic

Authored by pirama on Nov 10 2020, 11:32 AM.

Details

Summary

Previously we used setRegClass to rgpr, which may expand the register
domain if the result was already in a constrained class (tcgpr in the
above PR).

Diff Detail

Event Timeline

pirama created this revision.Nov 10 2020, 11:32 AM
pirama requested review of this revision.Nov 10 2020, 11:32 AM
dmgreen accepted this revision.Nov 10 2020, 12:41 PM

Hello. Nice test. Thanks for putting it together. LGTM

llvm/test/CodeGen/ARM/peephole-callee-save-regalloc.mir
9

Can you add a CHECK line for TCRETURNri, to show it's still using %5

This revision is now accepted and ready to land.Nov 10 2020, 12:41 PM
pirama updated this revision to Diff 304310.Nov 10 2020, 12:47 PM

Added CHECK line for TCRETURNri

This revision was landed with ongoing or failed builds.Nov 10 2020, 1:40 PM
This revision was automatically updated to reflect the committed changes.