This is an archive of the discontinued LLVM Phabricator instance.

Not pushing this one through CI right now, to save on CI time a bit, as it's rather trivial. On non-windows platforms, make_preferred() is a nop, so this should be safe for other platforms.

Rebased

Retrigger CI

Harbormaster completed remote builds in B89501: Diff 324212.Feb 17 2021, 11:46 AM

ldionne accepted this revision.Feb 19 2021, 11:00 AM

This revision is now accepted and ready to land.Feb 19 2021, 11:00 AM

Closed by commit rG513463fd266f: [libcxx] Have lexically_normal return the path with preferred separators (authored by mstorsjo). · Explain WhyFeb 19 2021, 11:11 AM

This revision was automatically updated to reflect the committed changes.

mstorsjo added a commit: rG513463fd266f: [libcxx] Have lexically_normal return the path with preferred separators.

Revision Contents

Path

Size

libcxx/

src/

filesystem/

operations.cpp

1 line

Diff 324211

libcxx/src/filesystem/operations.cpp

	Show First 20 Lines • Show All 991 Lines • ▼ Show 20 Lines
	path Result;			path Result;
	Result.__pn_.reserve(Parts.size() + NewPathSize + NeedTrailingSep);			Result.__pn_.reserve(Parts.size() + NewPathSize + NeedTrailingSep);
	for (auto& PK : Parts)			for (auto& PK : Parts)
	Result /= PK.first;			Result /= PK.first;

	if (NeedTrailingSep)			if (NeedTrailingSep)
	Result /= PS("");			Result /= PS("");

				Result.make_preferred();
	return Result;			return Result;
	}			}

	static int DetermineLexicalElementCount(PathParser PP) {			static int DetermineLexicalElementCount(PathParser PP) {
	int Count = 0;			int Count = 0;
	for (; PP; ++PP) {			for (; PP; ++PP) {
	auto Elem = *PP;			auto Elem = *PP;
	if (Elem == PS(".."))			if (Elem == PS(".."))
	▲ Show 20 Lines • Show All 267 Lines • Show Last 20 Lines

This is an archive of the discontinued LLVM Phabricator instance.

[23/N] [libcxx] Have lexically_normal return the path with preferred separatorsClosedPublic

Details

Diff Detail

Event Timeline

Revision Contents

Diff 324211

libcxx/src/filesystem/operations.cpp

[23/N] [libcxx] Have lexically_normal return the path with preferred separators
ClosedPublic