Differential D91136

[4/N] [libcxx] Reorder the two u8path functions, to make the following diff more readable. NFC.
ClosedPublic
Actions

Authored by mstorsjo on Nov 10 2020, 1:30 AM.

Tags

Subscribers

Details

Reviewers

EricWF
curdeius
ldionne

Group Reviewers

Restricted Project

Commits

rG48c6500b5bfa: [libcxx] Reorder the two u8path functions, to make the following diff more…

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

mstorsjo created this revision.Nov 10 2020, 1:30 AM

Herald added a project: Restricted Project. · View Herald TranscriptNov 10 2020, 1:30 AM

Herald added 1 blocking reviewer(s): Restricted Project. · View Herald Transcript

mstorsjo requested review of this revision.Nov 10 2020, 1:30 AM

mstorsjo added a parent revision: D91135: [3/N] [libcxx] Make filesystem::path::value_type wchar_t on windows.

Harbormaster completed remote builds in B78250: Diff 304088.Nov 10 2020, 1:31 AM

mstorsjo added a child revision: D91137: [5/N] [libcxx] Convert paths to/from the right narrow code page for narrow strings on windows.Nov 10 2020, 1:35 AM

mstorsjo added a reviewer: EricWF.Nov 21 2020, 6:17 AM

LGTM

Rebased

Rebased, readd the repository

Harbormaster completed remote builds in B81909: Diff 311015.Dec 10 2020, 2:46 PM

ldionne accepted this revision.Dec 14 2020, 3:19 PM

This revision is now accepted and ready to land.Dec 14 2020, 3:19 PM

Rebased on top of D93283.

Harbormaster completed remote builds in B82766: Diff 312437.Dec 17 2020, 6:11 AM

Closed by commit rG48c6500b5bfa: [libcxx] Reorder the two u8path functions, to make the following diff more… (authored by mstorsjo). · Explain WhyDec 18 2020, 1:25 AM

This revision was automatically updated to reflect the committed changes.

mstorsjo added a commit: rG48c6500b5bfa: [libcxx] Reorder the two u8path functions, to make the following diff more….

Revision Contents
Changeset List

Path

Size

libcxx/

include/

28 lines

Diff 312716

libcxx/include/filesystem

Loading...