Page MenuHomePhabricator

[mlir] Fix bug in use of rewiter for AtomicRMWOp.
ClosedPublic

Authored by tpopp on Nov 9 2020, 6:57 AM.

Details

Summary

The legalization did not forward the listener which prevents dynamic
legalization and prevents rollbacks. This handled that and then changed
the associated pass to support all other std ops to support partial
conversion.

Previously, this lowering was failing, but due to the
initial bug, the op's modifications were not reverted, and thus the
pattern matching succeeded.

Diff Detail

Event Timeline

tpopp created this revision.Nov 9 2020, 6:57 AM
tpopp requested review of this revision.Nov 9 2020, 6:57 AM
pifon2a accepted this revision.Nov 9 2020, 6:59 AM
This revision is now accepted and ready to land.Nov 9 2020, 6:59 AM
This revision was landed with ongoing or failed builds.Nov 9 2020, 7:00 AM
This revision was automatically updated to reflect the committed changes.