Page MenuHomePhabricator

[docs] link new support policy from developer policy
ClosedPublic

Authored by rengolin on Nov 7 2020, 1:19 PM.

Details

Summary

As requested in D90761, a small paragraph in the developer policy to
mention the different support levels.

Adding a new paragraph under "Adding an Existing Project" section to
check the different levels of support we have, to help introduction of
smaller set of changes without overwhelming new collaborators and
potentially losing the contribution.

Diff Detail

Event Timeline

rengolin created this revision.Nov 7 2020, 1:19 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 7 2020, 1:19 PM
rengolin requested review of this revision.Nov 7 2020, 1:19 PM

Looks great, but I'd add this to the top of the "adding a new thing" section above the "new target" section. Could you also revise the 'new target' to be defined in the terms you established? I think it makes sense to retain the majority of the text there, but aligning on terminology would be good.

Thanks again!

rengolin updated this revision to Diff 304130.Nov 10 2020, 4:06 AM

It's looking a bit redundant to me, but I wanted to make sure we have the link on all three sections in case people are given a link (or navigate from the table-of contents) and don't see the sections above.

This update adds:

  • Links to the support policy
  • Rewrite to accommodate existing style
  • Specified the level of cover for each topic
lattner accepted this revision.Nov 10 2020, 9:09 AM

I agree this is a bit redundant. I'd drop the two changes that I marked above in the diff, otherwise LGTM, thank you again!

llvm/docs/DeveloperPolicy.rst
702

I'd drop this mention.

726

and this mention

This revision is now accepted and ready to land.Nov 10 2020, 9:09 AM
This revision was automatically updated to reflect the committed changes.

Thanks for adding this Renato :-) I was out the first part of this week, but LGTM