Fixes for shared memory cleanup when aborts occur

[terdner]

Summary

We found a few cases that didn't properly clean up shared memory for openmp RTL registration when aborts occurred. This patch fixes those cases.

[AndreyChurbanov]

LGTM

openmp/runtime/src/kmp_runtime.cpp

/* On Windows* OS by default abort() causes pop-up error box, which stalls
        static OpenMP RTL). SetErrorMode (and so, timelimit utility) does not
        help, at least in some versions of MS C RTL.
 
        It seems following sequence is the only way to simulate abort() and
        avoid pop-up error box. */
     raise(SIGABRT);
     _exit(3); // Just in case, if signal ignored, exit anyway.
   } else {
+    __kmp_unregister_library();
     abort();
   }
 
   __kmp_infinite_loop();
   __kmp_release_bootstrap_lock(&__kmp_exit_lock);
 
 } // __kmp_abort_process
 
if (gtid == KMP_GTID_SHUTDOWN) {
       KA_TRACE(10, ("__kmp_internal_end_library: gtid not registered or system "
                     "shutdown\n"));
       /* we don't know who we are, but we may still shutdown the library */
     } else if (KMP_UBER_GTID(gtid)) {
       /* unregister ourselves as an uber thread.  gtid is no longer valid */
       if (__kmp_root[gtid]->r.r_active) {
         __kmp_global.g.g_abort = -1;
         TCW_SYNC_4(__kmp_global.g.g_done, TRUE);
+        __kmp_unregister_library();
         KA_TRACE(10,
                  ("__kmp_internal_end_library: root still active, abort T#%d\n",
                   gtid));
         return;
       } else {
         KA_TRACE(
             10,
             ("__kmp_internal_end_library: unregistering sibling T#%d\n", gtid));