This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [test] Fix TestGdbRemoteThreadName code on FreeBSD
ClosedPublic

Authored by mgorny on Nov 5 2020, 10:01 AM.

Details

Summary

Fix TestGdbRemoteThreadName to call ::pthread_setname_np instead
of ::pthread_set_name_np on FreeBSD. While technically both names
are correct, the former is preferable because of compatibility
with Linux. Furthermore, the latter requires #include <pthread_np.h>
that was missing causing the test to fail to compile.

Diff Detail

Event Timeline

mgorny created this revision.Nov 5 2020, 10:01 AM
mgorny requested review of this revision.Nov 5 2020, 10:01 AM

Note that D90863 is also required to fix the test.

emaste accepted this revision.Nov 5 2020, 10:56 AM
This revision is now accepted and ready to land.Nov 5 2020, 10:56 AM
krytarowski accepted this revision.Nov 5 2020, 11:42 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptNov 5 2020, 11:45 AM