[OpenMP] avoid warning: equality comparison with extraneous parentheses

[protze.joachim]

Summary

The macros are used in several places with an if(macro) pattern. This results in several warnings like:

llvm-project/openmp/runtime/src/kmp_wait_release.h:336:49: warning: equality comparison with extraneous parentheses [-Wparentheses-equality]
          if ((((task_team)->tt.tt_found_tasks) == (!0)))
               ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~
llvm-project/openmp/runtime/src/kmp_wait_release.h:801:16: note: in instantiation of function template specialization '__kmp_wait_template<kmp_flag_64, 0, true, false>' requested here
      retval = __kmp_wait_template<kmp_flag_64, 0, true, false>(
               ^
llvm-project/openmp/runtime/src/kmp_wait_release.h:336:49: note: remove extraneous parentheses around the comparison to silence this warning
          if ((((task_team)->tt.tt_found_tasks) == (!0)))
              ~                                 ^      ~
llvm-project/openmp/runtime/src/kmp_wait_release.h:336:49: note: use '=' to turn this equality comparison into an assignment
          if ((((task_team)->tt.tt_found_tasks) == (!0)))
                                                ^~
                                                =

Having the constant at the lhs of the comparison, avoids this warning.

[AndreyChurbanov]

LGTM

openmp/runtime/src/kmp.h

/* Minimum number of threads before switch to TLS gtid (experimentally
    determined) */
 /* josh TODO: what about OS X* tuning? */
 #if KMP_ARCH_X86 || KMP_ARCH_X86_64
 #define KMP_TLS_GTID_MIN 5
 #else
 #define KMP_TLS_GTID_MIN INT_MAX
 #endif
 
-#define KMP_MASTER_TID(tid) ((tid) == 0)
-#define KMP_WORKER_TID(tid) ((tid) != 0)
+#define KMP_MASTER_TID(tid) (0 == (tid))
+#define KMP_WORKER_TID(tid) (0 != (tid))
 
-#define KMP_MASTER_GTID(gtid) (__kmp_tid_from_gtid((gtid)) == 0)
-#define KMP_WORKER_GTID(gtid) (__kmp_tid_from_gtid((gtid)) != 0)
-#define KMP_INITIAL_GTID(gtid) ((gtid) == 0)
+#define KMP_MASTER_GTID(gtid) (0 == __kmp_tid_from_gtid((gtid)))
+#define KMP_WORKER_GTID(gtid) (0 != __kmp_tid_from_gtid((gtid)))
+#define KMP_INITIAL_GTID(gtid) (0 == (gtid))
 
 #ifndef TRUE
 #define FALSE 0
 #define TRUE (!FALSE)
 #endif
 
 /* NOTE: all of the following constants must be even */
 

 /* NOTE: kmp_taskdata_t and kmp_task_t structures allocated in single block with
    taskdata first */
 #define KMP_TASK_TO_TASKDATA(task) (((kmp_taskdata_t *)task) - 1)
 #define KMP_TASKDATA_TO_TASK(taskdata) (kmp_task_t *)(taskdata + 1)
 
 // The tt_found_tasks flag is a signal to all threads in the team that tasks
 // were spawned and queued since the previous barrier release.
 #define KMP_TASKING_ENABLED(task_team)                                         \
-  (TCR_SYNC_4((task_team)->tt.tt_found_tasks) == TRUE)
+  (TRUE == TCR_SYNC_4((task_team)->tt.tt_found_tasks))
 /*!
 @ingroup BASIC_TYPES
 @{
 */
 
 /*!
  */
 typedef kmp_int32 (*kmp_routine_entry_t)(kmp_int32, void *);