This is an archive of the discontinued LLVM Phabricator instance.

Differential D90684

[SVE][InstCombine] Improve specificity of InstCombine TypeSize test
ClosedPublic

Authored by joechrisellis on Nov 3 2020, 6:42 AM.

Details

Reviewers
sdesmalen
peterwaller-arm
efriedma
Commits
rGcf637a69e742: [SVE][InstCombine] Improve specificity of InstCombine TypeSize test
Summary

The test was using -O2, where -instcombine will suffice.

Diff Detail

Event Timeline

joechrisellis created this revision.Nov 3 2020, 6:42 AM
Herald added a reviewer: efriedma. · View Herald TranscriptNov 3 2020, 6:42 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: llvm-commits, psnobl, tschuett. · View Herald Transcript
joechrisellis requested review of this revision.Nov 3 2020, 6:42 AM
sdesmalen accepted this revision.Nov 3 2020, 6:44 AM

LGTM

This revision is now accepted and ready to land.Nov 3 2020, 6:44 AM
joechrisellis updated this revision to Diff 302573.Nov 3 2020, 6:58 AM

Get rid of -mtriple and -mattr flags, since these are also superfluous.

sdesmalen added a comment.Nov 3 2020, 7:12 AM

Thanks for removing the extra target flags @joechrisellis, that looks better now.

Harbormaster completed remote builds in B77403: Diff 302568.Nov 3 2020, 7:12 AM
This revision was landed with ongoing or failed builds.Nov 3 2020, 7:27 AM
Closed by commit rGcf637a69e742: [SVE][InstCombine] Improve specificity of InstCombine TypeSize test (authored by joechrisellis). · Explain Why
This revision was automatically updated to reflect the committed changes.
joechrisellis added a commit: rGcf637a69e742: [SVE][InstCombine] Improve specificity of InstCombine TypeSize test.
Harbormaster completed remote builds in B77406: Diff 302573.Nov 3 2020, 7:30 AM

Revision Contents

PathSize
llvm/
test/
Transforms/
InstCombine/
2 lines

Diff 302580

llvm/test/Transforms/InstCombine/gep-can-replace-gep-idx-with-zero-typesize.ll

; RUN: opt -S -O2 -mtriple=aarch64-linux-gnu -mattr=+sve < %s 2>%t ; RUN: opt -S -instcombine < %s 2>%t
; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t ; RUN: FileCheck --check-prefix=WARN --allow-empty %s <%t
; This regression test is verifying that the optimization defined by ; This regression test is verifying that the optimization defined by
; canReplaceGEPIdxWithZero, which replaces a GEP index with zero iff we can show ; canReplaceGEPIdxWithZero, which replaces a GEP index with zero iff we can show
; a value other than zero would cause undefined behaviour, does not throw a ; a value other than zero would cause undefined behaviour, does not throw a
; 'assumption that TypeSize is not scalable' warning when the source element type ; 'assumption that TypeSize is not scalable' warning when the source element type
; is a scalable vector. ; is a scalable vector.
Show All 16 Lines