The initial version of GWP-ASan on Fuchsia doesn't support crash and
signal handlers, so this just adds empty stubs to be able to compile
the project on the platform.
Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
Comment Actions
lgtm
compiler-rt/lib/gwp_asan/optional/segv_handler_fuchsia.cpp | ||
---|---|---|
16 | Another option is [[maybe_unused]] on each parameter. |
Comment Actions
LGTM w/ nit.
compiler-rt/lib/gwp_asan/optional/segv_handler_fuchsia.cpp | ||
---|---|---|
16 | Prefer void installSignalHandlers(gwp_asan::GuardedPoolAllocator * /* GPA */, Printf_t /* Printf */, PrintBacktrace_t /* PrintBacktrace */, SegvBacktrace_t /* SegvBacktrace */) { |
compiler-rt/lib/gwp_asan/optional/segv_handler_fuchsia.cpp | ||
---|---|---|
16 | You can also just omit parameter names altogether if they're unused. |
Another option is [[maybe_unused]] on each parameter.