This is an archive of the discontinued LLVM Phabricator instance.

Differential D90427

[llvm-readobj][NFC] Remove unused prefix from FileCheck tests
ClosedPublic

Authored by keith on Oct 29 2020, 2:02 PM.

Details

Reviewers
• espindola
jhenderson
rupprecht
Commits
rG29f9db7125af: [llvm-readobj][NFC] Remove unused prefix from FileCheck tests
Summary

This is to enable --allow-unused-duplicates=false. This prefix appears
to be outdated and intentionally unused.

Diff Detail

Event Timeline

keith created this revision.Oct 29 2020, 2:02 PM
Herald added a reviewer: • espindola. · View Herald TranscriptOct 29 2020, 2:02 PM
Herald added a reviewer: jhenderson. · View Herald Transcript
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: rupprecht, emaste. · View Herald Transcript
keith requested review of this revision.Oct 29 2020, 2:02 PM
Herald added a subscriber: MaskRay. · View Herald TranscriptOct 29 2020, 2:02 PM
Harbormaster completed remote builds in B76978: Diff 301748.Oct 29 2020, 2:30 PM
rupprecht accepted this revision.Oct 29 2020, 4:46 PM

Looks like it was D89384 that got rid of this, fwiw

This revision is now accepted and ready to land.Oct 29 2020, 4:46 PM
keith added a comment.Oct 29 2020, 5:35 PM

Thanks! I don't have commit access do you mind landing this for me?

rupprecht added a comment.Oct 29 2020, 5:50 PM

Sure, running tests now. You can get commit access via http://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access for future patches :)

keith added a comment.Oct 29 2020, 5:51 PM

Thanks! I actually just requested access so we'll see!

This revision was landed with ongoing or failed builds.Oct 29 2020, 5:54 PM
Closed by commit rG29f9db7125af: [llvm-readobj][NFC] Remove unused prefix from FileCheck tests (authored by keith, committed by rupprecht). · Explain Why
This revision was automatically updated to reflect the committed changes.
rupprecht added a commit: rG29f9db7125af: [llvm-readobj][NFC] Remove unused prefix from FileCheck tests.
grimar added a subscriber: grimar.Oct 29 2020, 11:53 PM

Thanks! That is what I've missed in D89384.

llvm/test/tools/llvm-readobj/ELF/needed-libs.test
61

You could use the --check-prefix then (without "es").
I've fixed this in rG16ab0b6778be81f1f79ae71b88a051b8ba5ca8f6

Revision Contents

PathSize
llvm/
test/
tools/
llvm-readobj/
ELF/
2 lines

Diff 301798

llvm/test/tools/llvm-readobj/ELF/needed-libs.test

Show First 20 Lines • Show All 52 Lines • ▼ Show 20 Lines - Type: PT_LOAD
VAddr: 0x0 VAddr: 0x0
Sections: Sections:
- Section: .dynstr - Section: .dynstr
- Section: .dynamic - Section: .dynamic
## Check what we print when the dynamic string table is empty. ## Check what we print when the dynamic string table is empty.
# RUN: yaml2obj %s --docnum=2 -o %t2 # RUN: yaml2obj %s --docnum=2 -o %t2
# RUN: llvm-readobj --needed-libs %t2 2>&1 | \ # RUN: llvm-readobj --needed-libs %t2 2>&1 | \
# RUN: FileCheck %s -DFILE=%t2 --implicit-check-not=warning: --check-prefixes=EMPTY-DYNSTR,EMPTY-DYNSTR-LLVM # RUN: FileCheck %s -DFILE=%t2 --implicit-check-not=warning: --check-prefixes=EMPTY-DYNSTR
grimarUnsubmitted
Not Done
ReplyInline Actions

You could use the --check-prefix then (without "es").
I've fixed this in rG16ab0b6778be81f1f79ae71b88a051b8ba5ca8f6

grimar: You could use the `--check-prefix` then (without "es"). I've fixed this in…
# RUN: llvm-readelf --needed-libs %t2 2>&1 | \ # RUN: llvm-readelf --needed-libs %t2 2>&1 | \
# RUN: FileCheck %s -DFILE=%t2 --implicit-check-not=warning: --check-prefix=EMPTY-DYNSTR # RUN: FileCheck %s -DFILE=%t2 --implicit-check-not=warning: --check-prefix=EMPTY-DYNSTR
# EMPTY-DYNSTR: NeededLibraries [ # EMPTY-DYNSTR: NeededLibraries [
# EMPTY-DYNSTR-NEXT: warning: '[[FILE]]': string table at offset 0x78: unable to read the string at 0x79: it goes past the end of the table (0x78) # EMPTY-DYNSTR-NEXT: warning: '[[FILE]]': string table at offset 0x78: unable to read the string at 0x79: it goes past the end of the table (0x78)
# EMPTY-DYNSTR-NEXT: warning: '[[FILE]]': string table at offset 0x78: unable to read the string at 0x7a: it goes past the end of the table (0x78) # EMPTY-DYNSTR-NEXT: warning: '[[FILE]]': string table at offset 0x78: unable to read the string at 0x7a: it goes past the end of the table (0x78)
# EMPTY-DYNSTR-NEXT: <?> # EMPTY-DYNSTR-NEXT: <?>
# EMPTY-DYNSTR-NEXT: <?> # EMPTY-DYNSTR-NEXT: <?>
Show All 32 Lines