This is an archive of the discontinued LLVM Phabricator instance.

[flang][driver] Use --match-full-lines in tests for `-test-io`
ClosedPublic

Authored by awarzynski on Oct 28 2020, 6:44 AM.

Details

Summary

Use --match-full-lines to make sure that FileCheck doesn't match the
output against the CHECK lines (which, like other comments, are also
printed).

More specifically, we want to make sure that the following check in the
input file:

! CHECK: <some-fortran-input>

is matched by FileCheck with <some-fortran-input> in the generated
output. Without --match-full-lines, that check-line will be matched
with !CHECK: <some-fortran-input> instead (which is also
printed together with other contents of the file).

Adding --match-full-lines makes the tests stricter and this change
revealed that some checks were passing only because that flag was
missing. These are updated accordingly.

Diff Detail

Event Timeline

awarzynski created this revision.Oct 28 2020, 6:44 AM
Herald added a project: Restricted Project. · View Herald Transcript
awarzynski requested review of this revision.Oct 28 2020, 6:44 AM
CarolineConcatto accepted this revision.Oct 28 2020, 7:43 AM

It looks good to me Andrzej.
As it is only test changes I do not expect this to be a problem outside flang.

This revision is now accepted and ready to land.Oct 28 2020, 7:43 AM
sameeranjoshi accepted this revision.Oct 29 2020, 11:37 PM