Page MenuHomePhabricator

[mlir] Properly handle recursive bufferization for scf.for/scf.if
ClosedPublic

Authored by silvas on Oct 26 2020, 5:58 PM.

Details

Summary

This fixes a subtle issue, described in the comment starting with
"Clone the op without the regions and inline the regions from the old op",
which prevented this conversion from working on non-trivial examples.

Diff Detail

Event Timeline

silvas created this revision.Oct 26 2020, 5:58 PM
silvas requested review of this revision.Oct 26 2020, 5:58 PM
rriddle accepted this revision.Oct 28 2020, 12:21 AM
rriddle added inline comments.
mlir/lib/Dialect/SCF/Transforms/StructuralTypeConversions.cpp
62

You aren't returning the failure here.

This revision is now accepted and ready to land.Oct 28 2020, 12:21 AM