Page MenuHomePhabricator

[mlir] Fix TypeID lookup in GDB pretty printers.
ClosedPublic

Authored by csigg on Oct 26 2020, 2:15 PM.

Details

Summary

The TypeID instance was moved in D89153.

It wasn't caught that it broke MLIR pretty printers because pre-merge checks don't run check-debuginfo.

Avoid disabling all MLIR printers in case this happens again by catching the exception.

Diff Detail

Event Timeline

csigg created this revision.Oct 26 2020, 2:15 PM
csigg requested review of this revision.Oct 26 2020, 2:15 PM
csigg edited the summary of this revision. (Show Details)Oct 26 2020, 2:17 PM
csigg added a reviewer: stellaraccident.
stellaraccident accepted this revision.Oct 26 2020, 10:14 PM

I had no idea. Thanks!

This revision is now accepted and ready to land.Oct 26 2020, 10:14 PM
This revision was automatically updated to reflect the committed changes.