This is an archive of the discontinued LLVM Phabricator instance.

Differential D90187

[NFC] Remove max_align.c LIT testcase
ClosedPublic

Authored by Xiangling_L on Oct 26 2020, 1:10 PM.

Details

Reviewers
hubert.reinterpretcast
jasonliu
daltenty
Commits
rG357715ce97d0: [NFC] Remove max_align.c LIT testcase
Summary

Since we fixed the definition of SuitableAlign here: https://reviews.llvm.org/D88659, max_align_t and __BIGGEST_ALIGNMENT__ are not necessarily the same always.

The original testcase was added here: https://reviews.llvm.org/D59048

Diff Detail

Event Timeline

Xiangling_L created this revision.Oct 26 2020, 1:10 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2020, 1:10 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Xiangling_L requested review of this revision.Oct 26 2020, 1:10 PM
hubert.reinterpretcast edited the summary of this revision. (Show Details)Oct 26 2020, 2:02 PM
Harbormaster completed remote builds in B76461: Diff 300773.Oct 26 2020, 2:02 PM
hubert.reinterpretcast accepted this revision.Oct 26 2020, 2:03 PM

LGTM; thanks.

This revision is now accepted and ready to land.Oct 26 2020, 2:03 PM
This revision was landed with ongoing or failed builds.Oct 26 2020, 2:15 PM
Closed by commit rG357715ce97d0: [NFC] Remove max_align.c LIT testcase (authored by Xiangling_L). · Explain Why
This revision was automatically updated to reflect the committed changes.
Xiangling_L added a commit: rG357715ce97d0: [NFC] Remove max_align.c LIT testcase.

Revision Contents

PathSize
clang/
test/
Headers/

Diff 300787

clang/test/Headers/max_align.c

  • This file was deleted.
// RUN: %clang_cc1 -fsyntax-only -std=c11 -verify %s
// expected-no-diagnostics
// XFAIL: windows-, i686
#ifndef __BIGGEST_ALIGNMENT__
#error __BIGGEST_ALIGNMENT__ not defined
#endif
#include <stddef.h>
_Static_assert(__BIGGEST_ALIGNMENT__ == _Alignof(max_align_t), "");