Page MenuHomePhabricator

[ARM][SchedModels] Convert IsLdstsoScaledNotOptimalPred to MCSchedPredicate
ClosedPublic

Authored by evgeny777 on Oct 26 2020, 5:02 AM.

Diff Detail

Event Timeline

evgeny777 created this revision.Oct 26 2020, 5:02 AM
evgeny777 requested review of this revision.Oct 26 2020, 5:02 AM

The new predicate looks good. I only have a couple of nits (see below).

llvm/lib/Target/ARM/ARMScheduleA57.td
45–59

I wonder if this could be formatted in a more readable way.
Maybe the CheckNot could go to a new line.
The last line might be split into multiple lines maybe. The >]>]>> sequence is not very nice.

53–55

What about the original isLdstScaledRegNotPlusLsl2 ?
Is it still used by something else other than the scheduling model?
If not, then it should be removed.

Much better. Thanks a lot :)

Assuming that the new numbers are correct, then the patch looks good to me.

dmgreen accepted this revision.Oct 26 2020, 8:51 AM

LGTM. Thanks

This revision is now accepted and ready to land.Oct 26 2020, 8:51 AM