Adding test cases
Update OpenMPOpt.cpp
Make cahnges in OpenMPOpt.cpp
Paths
| Differential D90103
Add OpenMP for optimization Needs ReviewPublic Authored by abidmalikwaterloo on Oct 24 2020, 12:44 PM.
Details
Diff Detail
Event TimelineHerald added projects: Restricted Project, Restricted Project. · View Herald TranscriptOct 24 2020, 12:44 PM Herald added subscribers: llvm-commits, openmp-commits, guansong and 2 others. · View Herald Transcript Comment Actions
Yes. I have tests. I will add it to the LIT and will update the patch. Comment Actions reverse ping. Also, I left comments in the original review that have not been addressed. Comment Actions
Previous patch: Comment Actions On the first look, you should at least clang-format this as it is not very readable right now. There are still no tests.
This comment was removed by abidmalikwaterloo.
Comment Actions
Yes, no need for new folder.
abidmalikwaterloo added inline comments.
abidmalikwaterloo marked an inline comment as done. Comment Actions
Comment Actions Added a test for OpenMP for loop fusion. Is the sample test acceptable? I can add more in the same format.
Comment Actions The optimization code is lacking in various regards. Let's focus on addressing the test remarks first in order to upstream those. We can revisit how to proceed with the optimization code after, e.g., revisit the algorithm from scratch.
Comment Actions I have a new patch that I wrote with LLVM-11 .0. The current patchwork is based on LLVM-9.0. The OpenMPOpt.CPP has a lot of modifications. What is the best way to submit the new patch? Any suggestion would be helpful.
Comment Actions
I would like to submit the tests along with the new patch. Some tests are failing with this patch. Or should I just submit all possible tests first ( whether the patch successfully runs or not)? Comment Actions
Comment Actions uploaded a new patch which is short and works on the cases without conditional statements Comment Actions Should I upload all potential tests in C/C++ format to define the scope of this patch? We can convert it to IR format later for upstreaming. Comment Actions Let's focus on the tests without the optimization code. On that front:
Comment Actions
Is there a set of other common passes that are required for this level of testing? Could not figure out from the other OpenMP IR test cases.
Comment Actions
I have cleaned it
Revision Contents
Diff 330235 .arcconfig
llvm/include/llvm/Frontend/OpenMP/OMPKinds.def
llvm/lib/Transforms/IPO/OpenMPOpt.cpp
llvm/test/Transforms/OpenMP/parallel_deletion.ll
llvm/test/Transforms/OpenMP/parallel_omp_for_loop_merge1.ll
openmp/runtime/src/kmp_sched.cpp
|
This seems unrelated.