Page MenuHomePhabricator
Differential D89954

[SCEV][NFC] Cache symbolic max exit count
ClosedPublic
Actions

Authored by mkazantsev on Oct 22 2020, 6:00 AM.

Details

Reviewers
nikic
efriedma
fhahn
lebedev.ri
Commits
rG6e574abf617c: [SCEV][NFC] Cache symbolic max exit count
Summary

We want to have a caching version of symbolic BE exit count
rather than recompute it every time we need it.

Diff Detail

Event Timeline

mkazantsev created this revision.Oct 22 2020, 6:00 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 22 2020, 6:00 AM
Herald added subscribers: llvm-commits, hiraditya. · View Herald Transcript
mkazantsev requested review of this revision.Oct 22 2020, 6:00 AM
mkazantsev added a child revision: D89381: [SCEV] Re-enable "Use nw flag and symbolic iteration count to sharpen ranges of AddRecs", attempt 3.
efriedma accepted this revision.Oct 22 2020, 12:59 PM

LGTM

This revision is now accepted and ready to land.Oct 22 2020, 12:59 PM
nikic accepted this revision.Oct 22 2020, 1:09 PM

LGTM as well.

llvm/include/llvm/Analysis/ScalarEvolution.h
747

Nit: This comment needs adjustment for constant -> symbolic.

1340–1341

Nit: The mention of ConstantMaxAndComplete is stale.

Closed by commit rG6e574abf617c: [SCEV][NFC] Cache symbolic max exit count (authored by mkazantsev). · Explain WhyOct 22 2020, 10:29 PM
This revision was automatically updated to reflect the committed changes.
mkazantsev added a commit: rG6e574abf617c: [SCEV][NFC] Cache symbolic max exit count.

Revision Contents
Changeset List

PathSize
llvm/
include/
llvm/
Analysis/
38 lines
lib/
Analysis/
18 lines
Transforms/
Scalar/
2 lines

Diff 300166

View Options

llvm/include/llvm/Analysis/ScalarEvolution.h

Loading...
View Options

llvm/lib/Analysis/ScalarEvolution.cpp

Loading...
View Options

llvm/lib/Transforms/Scalar/IndVarSimplify.cpp

Loading...