This is an archive of the discontinued LLVM Phabricator instance.

[LLD] [COFF] Align Extended DLL Characteristics

Authored by penzn on Oct 21 2020, 6:28 PM.



Match Extended DLL Characteristics alignment produced MSVC linker. Remove debug directory alignment introduced in D70606. This is required for CETCOMPAT setting to work in presence of other debug directories (CodeView, for example), otherwise it would not be recognizer by the Windows loader.

D89921 is a broader variant of this change.

Diff Detail

Event Timeline

penzn created this revision.Oct 21 2020, 6:28 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 21 2020, 6:28 PM
penzn requested review of this revision.Oct 21 2020, 6:28 PM
penzn edited the summary of this revision. (Show Details)Oct 21 2020, 7:18 PM

Both looks LGTM, but someone from LLD need needs to look at it.

thakis added a subscriber: thakis.Oct 22 2020, 12:37 PM

(Sounds like the plan is to move forward with the other patch.)

vitalybuka resigned from this revision.Nov 2 2020, 12:20 PM
penzn abandoned this revision.Nov 2 2020, 12:43 PM

Abandoned in favor of D89921