Page MenuHomePhabricator

[spirv] Fix legalize standard to spir-v for transfer ops
ClosedPublic

Authored by ThomasRaoux on Oct 21 2020, 1:03 PM.

Details

Summary

Forward missing attributes when creating the new transfer op otherwise the builder would use default values.

Diff Detail

Event Timeline

ThomasRaoux created this revision.Oct 21 2020, 1:03 PM
ThomasRaoux requested review of this revision.Oct 21 2020, 1:03 PM
antiagainst accepted this revision.Oct 21 2020, 1:33 PM

LGTM.

BTW, it seems we put these vector ops in std to spv patterns.. Should we move them to vector to spv given we have that directory now?

This revision is now accepted and ready to land.Oct 21 2020, 1:33 PM
mravishankar accepted this revision.Oct 21 2020, 1:38 PM

I think this is more related to legalizing the subview rather than the vector operation.

LGTM.

BTW, it seems we put these vector ops in std to spv patterns.. Should we move them to vector to spv given we have that directory now?

The downside is that we would not be able to share code as easily, there is very little code specific to transfer ops. As Mahesh mentioned this pass seems to deal more with subview ops than load/transfer ops