This is an archive of the discontinued LLVM Phabricator instance.

Differential D89840

These compiler-rt tests should be UNSUPPORTED instead of XFAIL.
ClosedPublic

Authored by aorlov on Oct 20 2020, 5:36 PM.

Details

Reviewers
vvereschaka
yroux
weimingz
Commits
rG9df832d1c3aa: These compiler-rt tests should be UNSUPPORTED instead of XFAIL.
Summary

These compiler-rt tests should be UNSUPPORTED instead of XFAIL, which seems to be the real intent of the authors.

Diff Detail

Unit TestsFailed

TimeTest
0 mslinux > Builtins-x86_64-linux.Builtins-x86_64-linux::gcc_personality_test.c
520 mswindows > Clang.CodeGen::basic-block-sections.c

Event Timeline

aorlov created this revision.Oct 20 2020, 5:36 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2020, 5:37 PM
Herald added subscribers: Restricted Project, dberris. · View Herald Transcript
aorlov requested review of this revision.Oct 20 2020, 5:37 PM
Harbormaster completed remote builds in B75796: Diff 299523.Oct 20 2020, 6:21 PM
vvereschaka added a comment.Oct 22 2020, 11:59 AM

Hi @aorlov,

UNSUPPORTED: * is not working actually. Please check a build log for linux > Builtins-x86_64-linux.Builtins-x86_64-linux::gcc_personality_test.c above. It says

ValueError: Error in UNSUPPORTED list:
couldn't parse text: '*'
in expression: '*'

in according of llvm/utils/lit/lit/BooleanExpression.py You may use true instead of * or just leave an empty expression, such UNSUPPORTED:. The 'true' expression keyword will be added into the empty list by default.

aorlov updated this revision to Diff 300085.Oct 22 2020, 12:56 PM
Harbormaster completed remote builds in B76083: Diff 300085.Oct 22 2020, 1:46 PM
vvereschaka accepted this revision.Oct 22 2020, 8:20 PM

LGTM

This revision is now accepted and ready to land.Oct 22 2020, 8:20 PM
This revision was landed with ongoing or failed builds.Oct 23 2020, 9:57 AM
Closed by commit rG9df832d1c3aa: These compiler-rt tests should be UNSUPPORTED instead of XFAIL. (authored by aorlov). · Explain Why
This revision was automatically updated to reflect the committed changes.
aorlov added a commit: rG9df832d1c3aa: These compiler-rt tests should be UNSUPPORTED instead of XFAIL..

Revision Contents

PathSize
compiler-rt/
test/
builtins/
Unit/
4 lines
crt/
2 lines

Diff 299523

compiler-rt/test/builtins/Unit/gcc_personality_test.c

// FIXME: XFAIL as currently it cannot be built by lit properly. // FIXME: UNSUPPORTED as currently it cannot be built by lit properly.
// XFAIL: * // UNSUPPORTED: *
// RUN: %clangxx_builtins %s %librt -o %t && %run %t // RUN: %clangxx_builtins %s %librt -o %t && %run %t
#include <stdlib.h> #include <stdlib.h>

compiler-rt/test/crt/dso_handle.cpp

Context not available.
// RUN: %clangxx -g -o %t -nostdlib %crt1 %crti %crtbegin %t.o %libstdcxx -lc -lm %libgcc %t.so %crtend %crtn // RUN: %clangxx -g -o %t -nostdlib %crt1 %crti %crtbegin %t.o %libstdcxx -lc -lm %libgcc %t.so %crtend %crtn
// RUN: %run %t 2>&1 | FileCheck %s // RUN: %run %t 2>&1 | FileCheck %s
// XFAIL: arm // UNSUPPORTED: arm
#include <stdio.h> #include <stdio.h>
Context not available.