These compiler-rt tests should be UNSUPPORTED instead of XFAIL.

[aorlov]

Summary

These compiler-rt tests should be UNSUPPORTED instead of XFAIL, which seems to be the real intent of the authors.

[vvereschaka]

Hi @aorlov,

UNSUPPORTED: * is not working actually. Please check a build log for linux > Builtins-x86_64-linux.Builtins-x86_64-linux::gcc_personality_test.c above. It says

ValueError: Error in UNSUPPORTED list:
couldn't parse text: '*'
in expression: '*'

in according of llvm/utils/lit/lit/BooleanExpression.py You may use true instead of * or just leave an empty expression, such UNSUPPORTED:. The 'true' expression keyword will be added into the empty list by default.

[vvereschaka]

LGTM

compiler-rt/test/builtins/Unit/gcc_personality_test.c

-// FIXME: XFAIL as currently it cannot be built by lit properly.
-// XFAIL: *
+// FIXME: UNSUPPORTED as currently it cannot be built by lit properly.
+// UNSUPPORTED: true
 // RUN: %clangxx_builtins %s %librt -o %t && %run %t
 
 #include <stdlib.h>
 #include <stdio.h>
 
 extern void foo_clean(void* x);
 extern void bar_clean(void* x);
 extern void register_foo_local(int* x);

compiler-rt/test/crt/dso_handle.cpp

 // RUN: %clangxx -g -DCRT_SHARED -c %s -fPIC -o %tshared.o
 // RUN: %clangxx -g -c %s -fPIC -o %t.o
 // RUN: %clangxx -g -shared -o %t.so -nostdlib %crti %crtbegin %tshared.o %libstdcxx -lc -lm %libgcc %crtend %crtn
 // RUN: %clangxx -g -o %t -nostdlib %crt1 %crti %crtbegin %t.o %libstdcxx -lc -lm %libgcc %t.so %crtend %crtn
 // RUN: %run %t 2>&1 | FileCheck %s
 
-// XFAIL: arm
+// UNSUPPORTED: arm, aarch64
 
 #include <stdio.h>
 
 // CHECK: 1
 // CHECK-NEXT: ~A()
 
 #ifdef CRT_SHARED
 bool G;