Page MenuHomePhabricator

[SystemZ][z/OS] Set short-enums as the default for z/OS
ClosedPublic

Authored by Jonathan.Crowther on Oct 20 2020, 8:48 AM.

Details

Summary

This patch sets short-enums to be the default for z/OS.

Diff Detail

Event Timeline

Herald added a project: Restricted Project. · View Herald TranscriptOct 20 2020, 8:48 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Jonathan.Crowther requested review of this revision.Oct 20 2020, 8:48 AM
Jonathan.Crowther retitled this revision from [SystemZ][ZOS] Set short-enums as the default for z/OS to [SystemZ][z/OS] Set short-enums as the default for z/OS.
SeanP added a subscriber: SeanP.Oct 20 2020, 9:25 AM
SeanP added inline comments.
clang/test/Driver/zos-driver-defaults.c
2

Can you add an additional test for -fno-short-enum to make sure that works too.

zibi added a subscriber: zibi.Oct 20 2020, 9:41 AM

LGTM, though not sure why comment is referencing -fshort-enums=0.
If '=0' is not significant perhaps delete it to remove confusion.

Added a test for -fno-short-enums

This revision is now accepted and ready to land.Oct 22 2020, 5:13 AM

Forgot to set the repository for my last patch. No code changes.

This revision was landed with ongoing or failed builds.Oct 22 2020, 11:16 AM
This revision was automatically updated to reflect the committed changes.