This is an archive of the discontinued LLVM Phabricator instance.

[NPM] Port module-debuginfo pass to the new pass manager
ClosedPublic

Authored by akhuang on Oct 19 2020, 1:51 PM.

Details

Summary

Port pass to NPM and update tests in DebugInfo/Generic.

Diff Detail

Event Timeline

akhuang created this revision.Oct 19 2020, 1:51 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2020, 1:51 PM
akhuang requested review of this revision.Oct 19 2020, 1:51 PM

a couple nits, otherwise lgtm

llvm/include/llvm/Analysis/ModuleDebugInfoPrinter.h
18

this shouldn't be needed

22
akhuang updated this revision to Diff 299169.Oct 19 2020, 2:23 PM
akhuang marked 2 inline comments as done.

clean up code

aeubanks accepted this revision.Oct 19 2020, 2:29 PM
This revision is now accepted and ready to land.Oct 19 2020, 2:29 PM
This revision was landed with ongoing or failed builds.Oct 19 2020, 2:31 PM
This revision was automatically updated to reflect the committed changes.