Page MenuHomePhabricator

[Sanitizer] Undefined Behavior Sanitizer support proposal for DragonFlyBSD
AcceptedPublic

Authored by devnexen on Oct 17 2020, 11:52 AM.

Details

Diff Detail

Event Timeline

devnexen created this revision.Oct 17 2020, 11:52 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 17 2020, 11:52 AM
Herald added subscribers: Restricted Project, phosek, jfb and 3 others. · View Herald Transcript
devnexen requested review of this revision.Oct 17 2020, 11:52 AM
krytarowski requested changes to this revision.Oct 17 2020, 1:19 PM

This contains unrelated code to ubsan/dragonflybsd. While there can you remove unsupported code for other OSs you introduced? That was never operational?

This revision now requires changes to proceed.Oct 17 2020, 1:19 PM

This contains unrelated code to ubsan/dragonflybsd. While there can you remove unsupported code for other OSs you introduced? That was never operational?

Well DragonFly does not support sanitizers that s kind of mandatory or should I cut into different differential ?

Please, First remove unused + unusable code for already introduced OS. At most cutting it to ubsan.

devnexen updated this revision to Diff 298892.Oct 18 2020, 11:31 AM

Focusing on ubsan change only

krytarowski resigned from this revision.Sat, Oct 31, 8:12 AM
vitalybuka accepted this revision.Mon, Nov 2, 12:19 PM

I have nothing against the patch in general but I am uncomfortable with the fact that I can accidentally undo this change and very likely I will know nothing about breakages for weeks.
Build bot which run just few times a week could be super helpful.

Also I am personally not sure if such unpopular distribution is worth of supporting, But some patches are already accepted by llvm, so this one is LGTM.
I hope we will not need to add a lot of special cases in other sanitizers and just keep them as unsupported.

This revision is now accepted and ready to land.Mon, Nov 2, 12:19 PM