[flang] Disallow pointer constants

[PeteSteinfeld]

Summary

None of the other Fortran compilers allow them.

[klausler]

Please add a comment that lays out our reasoning for the prohibition against combining PARAMETER and POINTER, since the standards do not explicitly preclude it. (The PARAMETER attribute requires a entity-decl to have an initialization that is a constant-expr, and the only form of initialization that allows a constant-expr is the one that's not a "=>" pointer initialization.) See C811, C807, & 8.5.13.

[PeteSteinfeld]

In D89581#2335561, @klausler wrote:

Please add a comment that lays out our reasoning for the prohibition against combining PARAMETER and POINTER, since the standards do not explicitly preclude it. (The PARAMETER attribute requires a entity-decl to have an initialization that is a constant-expr, and the only form of initialization that allows a constant-expr is the one that's not a "=>" pointer initialization.) See C811, C807, & 8.5.13.

Thanks for the detailed reasoning. I'll add a comment.

flang/lib/Semantics/check-declarations.cpp

if (isAssociated) {
     }
   }
 }
 
 void CheckHelper::CheckPointer(const Symbol &symbol) { // C852
   CheckConflicting(symbol, Attr::POINTER, Attr::TARGET);
   CheckConflicting(symbol, Attr::POINTER, Attr::ALLOCATABLE); // C751
   CheckConflicting(symbol, Attr::POINTER, Attr::INTRINSIC);
+  // Prohibit constant pointers.  The standard does not explicitly prohibit
+  // them, but the PARAMETER attribute requires a entity-decl to have an
+  // initialization that is a constant-expr, and the only form of
+  // initialization that allows a constant-expr is the one that's not a "=>"
+  // pointer initialization.  See C811, C807, and section 8.5.13.
+  CheckConflicting(symbol, Attr::POINTER, Attr::PARAMETER);
   if (symbol.Corank() > 0) {
     messages_.Say(
         "'%s' may not have the POINTER attribute because it is a coarray"_err_en_US,
         symbol.name());
   }
 }
 
 // C760 constraints on the passed-object dummy argument

flang/test/Semantics/resolve90.f90

 ! RUN: %S/test_errors.sh %s %t %f18
+! Testing for pointer constant, along with :
 ! C751 A component shall not have both the ALLOCATABLE and POINTER attributes.
 ! C752 If the CONTIGUOUS attribute is specified, the component shall be an 
 !   array with the POINTER attribute.
 ! C753 The * char-length option is permitted only if the component is of type 
 !   character.
 subroutine s()
+  !ERROR: 'nullint' may not have both the POINTER and PARAMETER attributes
+  integer, pointer, parameter :: nullint => null()
   type derivedType
     !ERROR: 'pointerallocatablefield' may not have both the POINTER and ALLOCATABLE attributes
     real, pointer, allocatable :: pointerAllocatableField
     real, dimension(:), contiguous, pointer :: goodContigField
     !ERROR: A CONTIGUOUS component must be an array with the POINTER attribute
     real, dimension(:), contiguous, allocatable :: badContigField
     character :: charField * 3
     !ERROR: A length specifier cannot be used to declare the non-character entity 'realfield'
     real :: realField * 3
   end type derivedType
 end subroutine s