llvm/utils/benchmark: add missing <limits> inclusion

[trofi]

Summary

Noticed missing header when was building llvm with gcc-11:

llvm-project/llvm/utils/benchmark/src/benchmark_register.h:17:30:
  error: 'numeric_limits' is not a member of 'std'
   17 |   static const T kmax = std::numeric_limits<T>::max();
      |                              ^~~~~~~~~~~~~~

Signed-off-by: Sergei Trofimovich <[e-mail]>

[lebedev.ri]

Right, but can you please submit this upstream first, so it doesn't get lost?

[trofi]

Sounds good! Proposed upstream as https://github.com/google/benchmark/pull/1060

[kbobyrev]

Thanks! After it is accepted in upstream benchmark, please add an entry to llvm/utils/benchmark/README.llvm which contains information about cherry-picked commits that are applied on top of the local copy.

[lebedev.ri]

In D89450#2331809, @kbobyrev wrote:

Thanks! After it is accepted in upstream benchmark, please add an entry to llvm/utils/benchmark/README.llvm which contains information about cherry-picked commits that are applied on top of the local copy.

To add to that, there are three copies of benchmark - one here, one in libcxx, and one in separate test-suite repo.
It might be good to patch all three.

[kbobyrev]

That's true and I was thinking about doing that at some point since it especially makes sense after the monorepo emerging on GitHub but I can't find enough time yet :( If anyone is willing to contribute or lead the way I'd be happy to review and help but I might not be able to do that myself right ntow.

[trofi]

Was fixed in b498303066a63a203d24f739b2d2e0e56dca70d1

[nvieen]

That’s this: ⚙ D89450 llvm/utils/benchmark: add missing <limits> inclusion You can just add #include <limits> for now; the next llvm upgrade should fix this.
for that specific version of llvm at 100%

llvm/utils/benchmark/src/benchmark_register.h

 #ifndef BENCHMARK_REGISTER_H
 #define BENCHMARK_REGISTER_H
 
+#include <limits>
 #include <vector>
 
 #include "check.h"
 
 template <typename T>
 void AddRange(std::vector<T>* dst, T lo, T hi, int mult) {
   CHECK_GE(lo, 0);
   CHECK_GE(hi, lo);