Page MenuHomePhabricator

[lld][WebAssembly] Don't GC library objects under `--whole-archive`
ClosedPublic

Authored by sbc100 on Oct 12 2020, 8:47 PM.

Details

Summary

Followup on https://reviews.llvm.org/D85062 which ignores
entire library objects when no symbols are used within them.
This is shouldn't apply with --whole-archive since this
is specified to treat them like direct object inputs.

Diff Detail

Event Timeline

sbc100 created this revision.Oct 12 2020, 8:47 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 12 2020, 8:47 PM
sbc100 requested review of this revision.Oct 12 2020, 8:47 PM

Looks like we raced to write this patch :)

sunfish accepted this revision.Oct 12 2020, 9:16 PM

LGTM; thanks for fixing this!

This revision is now accepted and ready to land.Oct 12 2020, 9:16 PM

I think mind is slightly less intrusive.. and I like having the single test. So I'll land this then.

This revision was landed with ongoing or failed builds.Oct 12 2020, 9:19 PM
This revision was automatically updated to reflect the committed changes.