Page MenuHomePhabricator

[WebAssembly] Don't GC constructors from libraries under --whole-archive
AbandonedPublic

Authored by sunfish on Oct 12 2020, 9:13 PM.

Details

Reviewers
sbc100
Summary

When --whole-archive is active, treat object files linked from archives
as live, and don't GC their constructors.

Diff Detail

Unit TestsFailed

TimeTest
3,990 mswindows > Clang-Unit.DirectoryWatcher/_/DirectoryWatcherTests_exe::DirectoryWatcherTest.AddFiles
Note: Google Test filter = DirectoryWatcherTest.AddFiles [==========] Running 1 test from 1 test case.
3,740 mswindows > Clang-Unit.DirectoryWatcher/_/DirectoryWatcherTests_exe::DirectoryWatcherTest.DeleteFile
Note: Google Test filter = DirectoryWatcherTest.DeleteFile [==========] Running 1 test from 1 test case.
3,840 mswindows > Clang-Unit.DirectoryWatcher/_/DirectoryWatcherTests_exe::DirectoryWatcherTest.ModifyFile
Note: Google Test filter = DirectoryWatcherTest.ModifyFile [==========] Running 1 test from 1 test case.

Event Timeline

sunfish created this revision.Oct 12 2020, 9:13 PM
sunfish requested review of this revision.Oct 12 2020, 9:13 PM

Wow you are fast :) do you prefer this solution over mine?

Either patch works for me. Yours is shorter :-).

sunfish abandoned this revision.Oct 13 2020, 5:53 AM

Abandoned in favor of https://reviews.llvm.org/D89290 .