The patch is generated using clang-tidy misc-use-override check.
This command was used:
tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py -checks='-*,misc-use-override' -header-filter='llvm|clang' -j=32 -fix
Paths
| Differential D8925
Use 'override/final' instead of 'virtual' for overridden methods ClosedPublic Authored by alexfh on Apr 9 2015, 10:26 AM.
Details
Summary The patch is generated using clang-tidy misc-use-override check. This command was used: tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py -checks='-*,misc-use-override' -header-filter='llvm|clang' -j=32 -fix
Diff Detail
Event TimelineComment Actions A lot of these seem to be destructors. Do we really want override on Comment Actions
Destructors are not much different from other methods in this regard: when you forget to specify virtual on the base class destructor, override on the derived one's will make compiler complain. Without override the code will compile fine, but will do something wrong. Comment Actions Recreated the patch using: tools/clang/tools/extra/clang-tidy/tool/run-clang-tidy.py -checks='-*,misc-use-override' -header-filter='llvm|clang' -j=32 -fix -format dblaikie edited edge metadata. Comment ActionsSounds good to me. This shouldn't really hurt blame any more than the existing transformations Ben did to add 'override' in the first place, so I don't see any disadvantage to this. This revision is now accepted and ready to land.Apr 10 2015, 4:37 PM
Revision Contents
Diff 23514 examples/ExceptionDemo/ExceptionDemo.cpp
examples/Kaleidoscope/Chapter3/toy.cpp
examples/Kaleidoscope/Chapter4/toy.cpp
examples/Kaleidoscope/Chapter5/toy.cpp
examples/Kaleidoscope/Chapter6/toy.cpp
examples/Kaleidoscope/Chapter7/toy.cpp
examples/Kaleidoscope/Chapter8/toy.cpp
include/llvm/Analysis/AssumptionCache.h
include/llvm/Analysis/BlockFrequencyInfo.h
include/llvm/Analysis/CallGraph.h
include/llvm/Analysis/DependenceAnalysis.h
include/llvm/Analysis/InlineCost.h
include/llvm/Analysis/JumpInstrTableInfo.h
include/llvm/Analysis/LazyValueInfo.h
include/llvm/Analysis/LibCallAliasAnalysis.h
include/llvm/Analysis/MemoryDependenceAnalysis.h
include/llvm/Analysis/PostDominators.h
include/llvm/Analysis/RegionInfo.h
include/llvm/CodeGen/AsmPrinter.h
include/llvm/CodeGen/LiveIntervalAnalysis.h
include/llvm/CodeGen/LiveRangeEdit.h
include/llvm/CodeGen/MachineBlockFrequencyInfo.h
include/llvm/CodeGen/MachineDominators.h
include/llvm/CodeGen/MachineFunctionAnalysis.h
include/llvm/CodeGen/MachineModuleInfo.h
include/llvm/CodeGen/MachinePassRegistry.h
include/llvm/CodeGen/MachinePostDominators.h
include/llvm/CodeGen/MachineRegionInfo.h
include/llvm/CodeGen/MachineScheduler.h
include/llvm/CodeGen/Passes.h
include/llvm/CodeGen/ScheduleDAGInstrs.h
include/llvm/CodeGen/SelectionDAGISel.h
include/llvm/CodeGen/TargetLoweringObjectFileImpl.h
include/llvm/DebugInfo/PDB/ConcreteSymbolEnumerator.h
include/llvm/ExecutionEngine/RTDyldMemoryManager.h
include/llvm/ExecutionEngine/SectionMemoryManager.h
include/llvm/IR/BasicBlock.h
include/llvm/IR/Constants.h
include/llvm/IR/Function.h
include/llvm/IR/GlobalValue.h
include/llvm/IR/GlobalVariable.h
include/llvm/IR/InlineAsm.h
include/llvm/IR/InstrTypes.h
include/llvm/IR/Instruction.h
include/llvm/IR/Instructions.h
include/llvm/IR/LegacyPassManager.h
include/llvm/IR/LegacyPassNameParser.h
include/llvm/IR/Metadata.h
include/llvm/IR/Operator.h
include/llvm/IR/User.h
include/llvm/LineEditor/LineEditor.h
include/llvm/MC/MCAsmInfoELF.h
include/llvm/MC/MCAssembler.h
include/llvm/MC/MCELFStreamer.h
include/llvm/MC/MCLinkerOptimizationHint.h
include/llvm/MC/MCObjectStreamer.h
include/llvm/MC/MCParser/AsmLexer.h
include/llvm/MC/MCSectionCOFF.h
include/llvm/MC/MCSectionELF.h
include/llvm/MC/MCStreamer.h
include/llvm/MC/MCTargetAsmParser.h
include/llvm/Object/IRObjectFile.h
include/llvm/Object/SymbolicFile.h
include/llvm/Option/ArgList.h
include/llvm/Pass.h
include/llvm/Support/FormattedStream.h
include/llvm/Support/YAMLTraits.h
include/llvm/Support/circular_raw_ostream.h
include/llvm/Support/raw_os_ostream.h
include/llvm/Support/raw_ostream.h
lib/Analysis/AliasAnalysisCounter.cpp
lib/Analysis/CFLAliasAnalysis.cpp
lib/Bitcode/Reader/BitcodeReader.cpp
lib/CodeGen/AggressiveAntiDepBreaker.h
lib/CodeGen/AsmPrinter/DwarfException.h
lib/CodeGen/AsmPrinter/EHStreamer.h
lib/CodeGen/AsmPrinter/Win64Exception.h
lib/CodeGen/AsmPrinter/WinCodeViewLineTables.h
lib/CodeGen/CodeGenPrepare.cpp
lib/CodeGen/CriticalAntiDepBreaker.h
lib/CodeGen/InlineSpiller.cpp
lib/CodeGen/LiveDebugVariables.h
lib/CodeGen/PostRASchedulerList.cpp
lib/CodeGen/SelectionDAG/ScheduleDAGRRList.cpp
lib/CodeGen/SelectionDAG/ScheduleDAGSDNodes.h
lib/CodeGen/SelectionDAG/ScheduleDAGVLIW.cpp
lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
lib/CodeGen/SpillPlacement.h
lib/CodeGen/WinEHPrepare.cpp
lib/DebugInfo/DWARF/DWARFDebugFrame.cpp
lib/DebugInfo/PDB/PDBSymbolFunc.cpp
lib/DebugInfo/PDB/PDBSymbolTypeFunctionSig.cpp
lib/ExecutionEngine/ExecutionEngineBindings.cpp
lib/ExecutionEngine/GDBRegistrationListener.cpp
lib/ExecutionEngine/Interpreter/Interpreter.h
lib/ExecutionEngine/MCJIT/MCJIT.h
lib/ExecutionEngine/Orc/OrcMCJITReplacement.h
lib/ExecutionEngine/RuntimeDyld/RuntimeDyldELF.h
lib/IR/LegacyPassManager.cpp
lib/MC/ELFObjectWriter.cpp
lib/MC/MCParser/AsmParser.cpp
lib/Support/CommandLine.cpp
lib/Support/DataStream.cpp
lib/Target/AArch64/MCTargetDesc/AArch64ELFObjectWriter.cpp
lib/Target/AArch64/MCTargetDesc/AArch64ELFStreamer.cpp
lib/Target/AArch64/MCTargetDesc/AArch64MCCodeEmitter.cpp
lib/Target/ARM/ARMConstantPoolValue.h
lib/Target/ARM/Disassembler/ARMDisassembler.cpp
lib/Target/ARM/MCTargetDesc/ARMELFObjectWriter.cpp
lib/Target/ARM/MCTargetDesc/ARMMCCodeEmitter.cpp
lib/Target/ARM/MCTargetDesc/ARMWinCOFFObjectWriter.cpp
lib/Target/Hexagon/MCTargetDesc/HexagonELFObjectWriter.cpp
lib/Target/Mips/MCTargetDesc/MipsELFObjectWriter.cpp
lib/Target/Mips/MCTargetDesc/MipsMCCodeEmitter.h
lib/Target/Mips/MCTargetDesc/MipsNaClELFStreamer.cpp
lib/Target/Mips/MipsOptionRecord.h
lib/Target/PowerPC/Disassembler/PPCDisassembler.cpp
lib/Target/PowerPC/MCTargetDesc/PPCMCCodeEmitter.cpp
lib/Target/PowerPC/PPCTargetStreamer.h
lib/Target/R600/MCTargetDesc/SIMCCodeEmitter.cpp
lib/Target/Sparc/MCTargetDesc/SparcELFObjectWriter.cpp
lib/Target/Sparc/MCTargetDesc/SparcMCCodeEmitter.cpp
lib/Target/Sparc/SparcSelectionDAGInfo.h
lib/Target/SystemZ/Disassembler/SystemZDisassembler.cpp
lib/Target/SystemZ/MCTargetDesc/SystemZMCCodeEmitter.cpp
lib/Target/SystemZ/MCTargetDesc/SystemZMCObjectWriter.cpp
lib/Target/X86/MCTargetDesc/X86ELFObjectWriter.cpp
lib/Target/X86/MCTargetDesc/X86MCCodeEmitter.cpp
lib/Target/X86/MCTargetDesc/X86WinCOFFObjectWriter.cpp
lib/Target/XCore/XCoreTargetStreamer.h
lib/Transforms/Scalar/AlignmentFromAssumptions.cpp
tools/bugpoint/ToolRunner.h
tools/lli/RemoteMemoryManager.h
tools/lli/RemoteTargetExternal.h
tools/lli/lli.cpp
unittests/ADT/DAGDeltaAlgorithmTest.cpp
unittests/ADT/DeltaAlgorithmTest.cpp
unittests/ADT/SmallVectorTest.cpp
unittests/Analysis/CFGTest.cpp
unittests/Analysis/ScalarEvolutionTest.cpp
unittests/ExecutionEngine/ExecutionEngineTest.cpp
unittests/ExecutionEngine/MCJIT/MCJITCAPITest.cpp
unittests/ExecutionEngine/MCJIT/MCJITObjectCacheTest.cpp
unittests/ExecutionEngine/MCJIT/MCJITTest.cpp
unittests/IR/DominatorTreeTest.cpp
unittests/IR/IRBuilderTest.cpp
unittests/IR/ValueHandleTest.cpp
unittests/LineEditor/LineEditor.cpp
unittests/Linker/LinkModulesTest.cpp
unittests/Support/AlignOfTest.cpp
unittests/Support/CommandLineTest.cpp
unittests/Support/MemoryBufferTest.cpp
unittests/Support/Path.cpp
unittests/Transforms/Utils/Cloning.cpp
utils/TableGen/DAGISelMatcher.h
utils/unittest/googletest/include/gtest/gtest-spi.h
utils/unittest/googletest/include/gtest/gtest-test-part.h
utils/unittest/googletest/include/gtest/gtest.h
utils/unittest/googletest/include/gtest/internal/gtest-death-test-internal.h
utils/unittest/googletest/include/gtest/internal/gtest-internal.h
utils/unittest/googletest/include/gtest/internal/gtest-param-util.h
utils/unittest/googletest/include/gtest/internal/gtest-port.h
utils/unittest/googletest/src/gtest-death-test.cc
utils/unittest/googletest/src/gtest-internal-inl.h
utils/unittest/googletest/src/gtest.cc
|