[lldb] [Process/FreeBSDRemote] Kill process via PT_KILL

[mgorny]

Summary

Use PT_KILL to kill the stopped process. This ensures that the process
termination is reported properly and fixes delay/error on killing it.

[labath]

FWIW, PTHREAD_KILL is strongly discouraged on linux. But if the situation is different on freebsd, then fine.

[krytarowski]

In D89182#2324267, @labath wrote:

FWIW, PTHREAD_KILL is strongly discouraged on linux. But if the situation is different on freebsd, then fine.

I think you mean PTRACE_KILL. PT_KILL is fine for BSDs and in case when it is not, it should be fixed.

lldb/source/Plugins/Process/FreeBSDRemote/NativeProcessFreeBSD.cpp

Status NativeProcessFreeBSD::Kill() {
   case StateType::eStateStopped:
   case StateType::eStateRunning:
   case StateType::eStateStepping:
   case StateType::eStateSuspended:
     // We can try to kill a process in these states.
     break;
   }
 
-  if (kill(GetID(), SIGKILL) != 0) {
-    error.SetErrorToErrno();
-    return error;
-  }
-
-  return error;
+  return PtraceWrapper(PT_KILL, m_pid);
 }
 
 Status NativeProcessFreeBSD::GetMemoryRegionInfo(lldb::addr_t load_addr,
                                                  MemoryRegionInfo &range_info) {
 
   if (m_supports_mem_region == LazyBool::eLazyBoolNo) {
     // We're done.
     return Status("unsupported");