Page MenuHomePhabricator

[lldb] [Process/FreeBSDRemote] Kill process via PT_KILL
ClosedPublic

Authored by mgorny on Oct 10 2020, 12:39 AM.

Details

Summary

Use PT_KILL to kill the stopped process. This ensures that the process
termination is reported properly and fixes delay/error on killing it.

Diff Detail

Event Timeline

mgorny requested review of this revision.Oct 10 2020, 12:39 AM
mgorny created this revision.
krytarowski accepted this revision.Oct 10 2020, 2:40 AM
This revision is now accepted and ready to land.Oct 10 2020, 2:40 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptOct 10 2020, 9:56 AM

FWIW, PTHREAD_KILL is strongly discouraged on linux. But if the situation is different on freebsd, then fine.

FWIW, PTHREAD_KILL is strongly discouraged on linux. But if the situation is different on freebsd, then fine.

I think you mean PTRACE_KILL. PT_KILL is fine for BSDs and in case when it is not, it should be fixed.