This is an archive of the discontinued LLVM Phabricator instance.

[AIX] Support two itanium alignment LIT testcases for AIX using regex
ClosedPublic

Authored by Xiangling_L on Oct 8 2020, 12:26 PM.

Details

Summary

AIX has different layout dumping format from other itanium abis.
And for these two cases, use regex to match AIX format.

Diff Detail

Event Timeline

Xiangling_L created this revision.Oct 8 2020, 12:26 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2020, 12:26 PM
Herald added a subscriber: cfe-commits. · View Herald Transcript
Xiangling_L requested review of this revision.Oct 8 2020, 12:26 PM

Can we use a regex to make this also work in AIX?

Can we use a regex to make this also work in AIX?

Sure we can also do that. May I ask is that because we prefer letting AIX support as many LIT testcases as possible?

Can we use a regex to make this also work in AIX?

Sure we can also do that. May I ask is that because we prefer letting AIX support as many LIT testcases as possible?

Yes. In particular, if there was a reason for these cases to get expanded in the future, we'd like AIX to be tested as well.

Use regex to match AIX layout dumping format.

Xiangling_L retitled this revision from [AIX] Disable two itanium alignment LIT testcases to [AIX] Support two itanium alignment LIT testcases for AIX using regex.Oct 13 2020, 6:53 AM
Xiangling_L edited the summary of this revision. (Show Details)

LGTM with suggestion.

clang/test/Layout/itanium-pack-and-align.cpp
19–20

If it works, use ? in place of *. Do also for all of the other cases.

This revision is now accepted and ready to land.Oct 13 2020, 6:57 AM